Re: [PATCH v4 3/4] xen/ppc: Implement early serial printk on pseries

2023-07-24 Thread Jan Beulich
On 21.07.2023 18:53, Shawn Anastasio wrote: > On 7/19/23 9:05 AM, Jan Beulich wrote: >> On 18.07.2023 22:20, Shawn Anastasio wrote: >>> +void __init boot_of_init(unsigned long vec) >>> +{ >>> +int bof_chosen; >>> + >>> +of_vec = vec; >>> + >>> +/* Get a handle to the default console */

Re: [PATCH v4 3/4] xen/ppc: Implement early serial printk on pseries

2023-07-21 Thread Shawn Anastasio
On 7/19/23 9:05 AM, Jan Beulich wrote: > On 18.07.2023 22:20, Shawn Anastasio wrote: >> +void __init boot_of_init(unsigned long vec) >> +{ >> +int bof_chosen; >> + >> +of_vec = vec; >> + >> +/* Get a handle to the default console */ >> +bof_chosen = of_finddevice("/chosen"); >> +

Re: [PATCH v4 3/4] xen/ppc: Implement early serial printk on pseries

2023-07-20 Thread Jan Beulich
On 20.07.2023 23:01, Shawn Anastasio wrote: > On 7/19/23 9:05 AM, Jan Beulich wrote: >> Before you/we grow more assembly code, may I re-raise a request regarding >> readability: I think it would be nice if operands started at a fixed column, >> unless the insn mnemonic is unusually long. Where exac

Re: [PATCH v4 3/4] xen/ppc: Implement early serial printk on pseries

2023-07-20 Thread Shawn Anastasio
On 7/19/23 9:05 AM, Jan Beulich wrote: > Before you/we grow more assembly code, may I re-raise a request regarding > readability: I think it would be nice if operands started at a fixed column, > unless the insn mnemonic is unusually long. Where exactly to draw the line > is up to each archtecture;

Re: [PATCH v4 3/4] xen/ppc: Implement early serial printk on pseries

2023-07-19 Thread Jan Beulich
On 18.07.2023 22:20, Shawn Anastasio wrote: > +void __init boot_of_init(unsigned long vec) > +{ > +int bof_chosen; > + > +of_vec = vec; > + > +/* Get a handle to the default console */ > +bof_chosen = of_finddevice("/chosen"); > +of_getprop(bof_chosen, "stdout", &of_out, sizeof(

[PATCH v4 3/4] xen/ppc: Implement early serial printk on pseries

2023-07-18 Thread Shawn Anastasio
On typical Power VMs (e.g. QEMU's -M pseries), a variety of services including an early serial console are provided by Open Firmware. Implement the required interfaces to call into Open Firmware and write to the serial console. Since Open Firmware runs in 32-bit Big Endian mode and Xen runs in 64-