Hi,
On Thu, Jul 28, 2022 at 9:41 PM Julien Grall wrote:
>
> Hi,
>
> On 27/07/2022 07:33, Jens Wiklander wrote:
> > On Fri, Jul 8, 2022 at 9:54 PM Julien Grall wrote:
> >>> +unsigned int n;
> >>> +unsigned int m;
> >>> +p2m_type_t t;
> >>> +uint64_t addr;
> >>> +
> >>> +for (
Hi,
On Thu, Jul 28, 2022 at 9:15 PM Julien Grall wrote:
>
> Hi,
>
> On 26/07/2022 07:17, Jens Wiklander wrote:
> > On Fri, Jul 8, 2022 at 3:41 PM Julien Grall wrote:
> >>
> >> Hi Jens,
> >>
> >> I haven't checked whether the FFA driver is complaint with the spec. I
> >> mainly checked whether th
Hi,
On 27/07/2022 07:33, Jens Wiklander wrote:
On Fri, Jul 8, 2022 at 9:54 PM Julien Grall wrote:
+unsigned int n;
+unsigned int m;
+p2m_type_t t;
+uint64_t addr;
+
+for ( n = 0; n < range_count; n++ )
+{
+for ( m = 0; m < range[n].page_count; m++ )
+{
+
Hi,
On 26/07/2022 07:17, Jens Wiklander wrote:
On Fri, Jul 8, 2022 at 3:41 PM Julien Grall wrote:
Hi Jens,
I haven't checked whether the FFA driver is complaint with the spec. I
mainly checked whether the code makes sense from Xen PoV.
This is a fairly long patch to review. So I will split
Hi Bertrand,
On Thu, Jul 14, 2022 at 11:51 AM Bertrand Marquis
wrote:
>
> Hi Jens,
>
> > On 22 Jun 2022, at 14:42, Jens Wiklander wrote:
> >
> > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure
> > Partition in secure world.
> >
> > The implementation is the bare minimum to be a
Hi Julien,
On Fri, Jul 8, 2022 at 9:54 PM Julien Grall wrote:
>
> Hi Jens,
>
> This is the second part of the review.
>
> On 22/06/2022 14:42, Jens Wiklander wrote:
> > +static int get_shm_pages(struct domain *d, struct ffa_shm_mem *shm,
> > + struct ffa_address_range *ran
Hi Julien,
On Fri, Jul 8, 2022 at 3:41 PM Julien Grall wrote:
>
> Hi Jens,
>
> I haven't checked whether the FFA driver is complaint with the spec. I
> mainly checked whether the code makes sense from Xen PoV.
>
> This is a fairly long patch to review. So I will split my review in
> multiple sess
Hi Julien,
On Fri, Jul 08, 2022 at 02:40:56PM +0100, Julien Grall wrote:
> Hi Jens,
>
> I haven't checked whether the FFA driver is complaint with the spec. I
> mainly checked whether the code makes sense from Xen PoV.
>
> This is a fairly long patch to review. So I will split my review in multi
Hi Jens,
> On 22 Jun 2022, at 14:42, Jens Wiklander wrote:
>
> Adds a FF-A version 1.1 [1] mediator to communicate with a Secure
> Partition in secure world.
>
> The implementation is the bare minimum to be able to communicate with
> OP-TEE running as an SPMC at S-EL1.
>
> This is loosely base
Hi Jens,
Just to let you know, I am currently going through the spec in order to
properly review your implementation but this might take a bit of time as it is
quite long :-)
Cheers
Bertrand
> On 22 Jun 2022, at 14:42, Jens Wiklander wrote:
>
> Adds a FF-A version 1.1 [1] mediator to communi
Hi Jens,
This is the second part of the review.
On 22/06/2022 14:42, Jens Wiklander wrote:
+static int get_shm_pages(struct domain *d, struct ffa_shm_mem *shm,
+ struct ffa_address_range *range, uint32_t range_count,
AFAICT, 'range' is not meant to be modified. So I wo
Hi Jens,
I haven't checked whether the FFA driver is complaint with the spec. I
mainly checked whether the code makes sense from Xen PoV.
This is a fairly long patch to review. So I will split my review in
multiple session/e-mail.
On 22/06/2022 14:42, Jens Wiklander wrote:
Adds a FF-A vers
Adds a FF-A version 1.1 [1] mediator to communicate with a Secure
Partition in secure world.
The implementation is the bare minimum to be able to communicate with
OP-TEE running as an SPMC at S-EL1.
This is loosely based on the TEE mediator framework and the OP-TEE
mediator.
[1] https://develope
13 matches
Mail list logo
