RE: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-05-23 Thread Henry Wang
Hi Jan, > -Original Message- > On 23.05.2023 09:32, Henry Wang wrote: > > By looking into the existing implementation of NUMA for DT, > > in Linux, from drivers/base/arch_numa.c: numa_set_distance(), there is a > > "if ((u8)distance != distance)" then return. So I think at least in Linux

Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-05-23 Thread Jan Beulich
On 23.05.2023 09:32, Henry Wang wrote: >> -Original Message- >> Subject: Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device >> tree NUMA distance map >> >>>>>> The [2] link you provided discusses NUMA_LOCAL_DISTANCE. >>>>

RE: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-05-23 Thread Henry Wang
Hi Jan, > -Original Message- > Subject: Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device > tree NUMA distance map > > >>>> The [2] link you provided discusses NUMA_LOCAL_DISTANCE. > >>> > >>> I inferred the discussi

Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-05-22 Thread Jan Beulich
On 23.05.2023 08:31, Henry Wang wrote: >> -Original Message- >> Subject: Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device >> tree NUMA distance map >> >>>>>>> +/* The default value in node_distance_map is >&g

RE: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-05-22 Thread Henry Wang
Hi Jan, > -Original Message- > Subject: Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device > tree NUMA distance map > > >>>>> +/* The default value in node_distance_map is > >> NUMA_NO_DISTANCE > >>>>

RE: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-04-26 Thread Henry Wang
Hi Jan > -Original Message- > From: Henry Wang > Subject: RE: [PATCH v4 09/17] xen/arm: introduce a helper to parse device > tree NUMA distance map > > Hi Jan, > > > -Original Message- > > From: Jan Beulich > > Subject: Re: [PATCH v4 09/1

RE: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-04-26 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device > tree NUMA distance map > > > Great points! Thanks for pointing the 8-bit truncation out. You are correct. > > Somehow my impressi

Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-04-26 Thread Jan Beulich
On 26.04.2023 09:36, Henry Wang wrote: >> -Original Message- >> From: Jan Beulich >> >> On 26.04.2023 08:29, Henry Wang wrote: -Original Message- From: Jan Beulich > +distance = dt_next_cell(1, &matrix); Upon second thought I checked what dt_ne

RE: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-04-26 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device > tree NUMA distance map > > On 26.04.2023 08:29, Henry Wang wrote: > >> -Original Message- > >> From: Jan B

Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-04-26 Thread Jan Beulich
On 26.04.2023 09:08, Henry Wang wrote: > Hi Jan, > >> -Original Message- >> From: Jan Beulich >> Subject: Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device >> tree NUMA distance map >> >> On 26.04.2023 07:33, Henry Wang wrote: >

RE: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-04-26 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device > tree NUMA distance map > > On 26.04.2023 07:33, Henry Wang wrote: > >> -Original Message- > >> From: Jan Beulich

Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-04-26 Thread Jan Beulich
On 26.04.2023 08:29, Henry Wang wrote: >> -Original Message- >> From: Jan Beulich >> >>> +distance = dt_next_cell(1, &matrix); >> >> Upon second thought I checked what dt_next_cell() returns: You're silently >> truncating here and then ... >> >>> +/* Bi-directions are n

Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-04-25 Thread Jan Beulich
On 26.04.2023 07:33, Henry Wang wrote: >> -Original Message- >> From: Jan Beulich >> >>> +/* Get opposite way distance */ >>> +opposite = __node_distance(to, from); >>> +/* The default value in node_distance_map is NUMA_NO_DISTANCE >> */ >>> +if ( opposite =

RE: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-04-25 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device > tree NUMA distance map > > > +distance = dt_next_cell(1, &matrix); > > Upon second thought I checked what dt_next_

RE: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-04-25 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device > tree NUMA distance map > > > +unsigned int from, to, distance, opposite; > > With these ... > > > +

Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-04-25 Thread Jan Beulich
On 25.04.2023 09:56, Henry Wang wrote: > --- a/xen/arch/arm/numa_device_tree.c > +++ b/xen/arch/arm/numa_device_tree.c > @@ -151,3 +151,111 @@ invalid_data: > numa_fw_bad(); > return -EINVAL; > } > + > +/* Parse NUMA distance map v1 */ > +static int __init fdt_parse_numa_distance_map_v1(

Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-04-25 Thread Jan Beulich
On 25.04.2023 09:56, Henry Wang wrote: > From: Wei Chen > > A NUMA aware device tree will provide a "distance-map" node to > describe distance between any two nodes. This patch introduce a > new helper to parse this distance map. > > Signed-off-by: Wei Chen > Signed-off-by: Henry Wang While t

[PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-04-25 Thread Henry Wang
From: Wei Chen A NUMA aware device tree will provide a "distance-map" node to describe distance between any two nodes. This patch introduce a new helper to parse this distance map. Signed-off-by: Wei Chen Signed-off-by: Henry Wang --- v3 -> v4: 1. The distance map default value is now NUMA_NO_