Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-22 Thread Oleksandr Andrushchenko
On 22.11.21 10:24, Jan Beulich wrote: > On 19.11.2021 15:09, Oleksandr Andrushchenko wrote: >> On 19.11.21 15:57, Jan Beulich wrote: >>> On 19.11.2021 14:41, Oleksandr Andrushchenko wrote: On 19.11.21 15:16, Jan Beulich wrote: > On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: >>

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-22 Thread Jan Beulich
On 19.11.2021 15:09, Oleksandr Andrushchenko wrote: > On 19.11.21 15:57, Jan Beulich wrote: >> On 19.11.2021 14:41, Oleksandr Andrushchenko wrote: >>> On 19.11.21 15:16, Jan Beulich wrote: On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: > @@ -95,10 +102,25 @@ int vpci_add_handlers(stru

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-19 Thread Oleksandr Andrushchenko
On 19.11.21 15:57, Jan Beulich wrote: > On 19.11.2021 14:41, Oleksandr Andrushchenko wrote: >> >> On 19.11.21 15:16, Jan Beulich wrote: >>> On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: @@ -95,10 +102,25 @@ int vpci_add_handlers(struct pci_dev *pdev) INIT_LIST_HEAD(&pdev->v

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-19 Thread Jan Beulich
On 19.11.2021 14:41, Oleksandr Andrushchenko wrote: > > > On 19.11.21 15:16, Jan Beulich wrote: >> On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: >>> @@ -95,10 +102,25 @@ int vpci_add_handlers(struct pci_dev *pdev) >>> INIT_LIST_HEAD(&pdev->vpci->handlers); >>> spin_lock_init(&pd

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-19 Thread Oleksandr Andrushchenko
On 19.11.21 15:16, Jan Beulich wrote: > On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: >> @@ -95,10 +102,25 @@ int vpci_add_handlers(struct pci_dev *pdev) >> INIT_LIST_HEAD(&pdev->vpci->handlers); >> spin_lock_init(&pdev->vpci->lock); >> >> +header = &pdev->vpci->header; >

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-19 Thread Oleksandr Andrushchenko
On 19.11.21 15:29, Jan Beulich wrote: > On 19.11.2021 14:19, Oleksandr Andrushchenko wrote: >> >> On 19.11.21 15:06, Jan Beulich wrote: >>> On 19.11.2021 13:50, Oleksandr Andrushchenko wrote: On 19.11.21 14:45, Jan Beulich wrote: > On 19.11.2021 13:13, Oleksandr Andrushchenko wrote:

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-19 Thread Jan Beulich
On 19.11.2021 14:19, Oleksandr Andrushchenko wrote: > > > On 19.11.21 15:06, Jan Beulich wrote: >> On 19.11.2021 13:50, Oleksandr Andrushchenko wrote: >>> On 19.11.21 14:45, Jan Beulich wrote: On 19.11.2021 13:13, Oleksandr Andrushchenko wrote: > On 19.11.21 14:05, Jan Beulich wrote: >>>

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-19 Thread Oleksandr Andrushchenko
On 19.11.21 15:06, Jan Beulich wrote: > On 19.11.2021 13:50, Oleksandr Andrushchenko wrote: >> On 19.11.21 14:45, Jan Beulich wrote: >>> On 19.11.2021 13:13, Oleksandr Andrushchenko wrote: On 19.11.21 14:05, Jan Beulich wrote: > On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: >>

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-19 Thread Jan Beulich
On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: > @@ -95,10 +102,25 @@ int vpci_add_handlers(struct pci_dev *pdev) > INIT_LIST_HEAD(&pdev->vpci->handlers); > spin_lock_init(&pdev->vpci->lock); > > +header = &pdev->vpci->header; > +for ( i = 0; i < ARRAY_SIZE(header->bars); i

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-19 Thread Jan Beulich
On 19.11.2021 13:50, Oleksandr Andrushchenko wrote: > On 19.11.21 14:45, Jan Beulich wrote: >> On 19.11.2021 13:13, Oleksandr Andrushchenko wrote: >>> On 19.11.21 14:05, Jan Beulich wrote: On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Inst

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-19 Thread Oleksandr Andrushchenko
On 19.11.21 14:45, Jan Beulich wrote: > On 19.11.2021 13:13, Oleksandr Andrushchenko wrote: >> On 19.11.21 14:05, Jan Beulich wrote: >>> On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Instead of handling a single range set, that contains all the

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-19 Thread Jan Beulich
On 19.11.2021 13:13, Oleksandr Andrushchenko wrote: > On 19.11.21 14:05, Jan Beulich wrote: >> On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> Instead of handling a single range set, that contains all the memory >>> regions of all the BARs and ROM, hav

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-19 Thread Oleksandr Andrushchenko
On 19.11.21 14:05, Jan Beulich wrote: > On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> Instead of handling a single range set, that contains all the memory >> regions of all the BARs and ROM, have them per BAR. > Iirc Roger did indicate agreement with

Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-19 Thread Jan Beulich
On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Instead of handling a single range set, that contains all the memory > regions of all the BARs and ROM, have them per BAR. Iirc Roger did indicate agreement with the spitting. May I nevertheless ask that for

[PATCH v4 06/11] vpci/header: handle p2m range sets per BAR

2021-11-04 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Instead of handling a single range set, that contains all the memory regions of all the BARs and ROM, have them per BAR. This is in preparation of making non-identity mappings in p2m for the MMIOs/ROM. Signed-off-by: Oleksandr Andrushchenko --- Since v3: - re-wor