Re: [PATCH v4 03/10] libx86: introduce helper to fetch msr entry

2021-05-18 Thread Jan Beulich
On 18.05.2021 12:50, Roger Pau Monné wrote: > On Mon, May 17, 2021 at 05:43:33PM +0200, Jan Beulich wrote: >> On 07.05.2021 13:04, Roger Pau Monne wrote: >>> @@ -91,6 +91,21 @@ int x86_msr_copy_from_buffer(struct msr_policy *policy, >>> const msr_entry_buffer_t msrs, u

Re: [PATCH v4 03/10] libx86: introduce helper to fetch msr entry

2021-05-18 Thread Roger Pau Monné
On Mon, May 17, 2021 at 05:43:33PM +0200, Jan Beulich wrote: > On 07.05.2021 13:04, Roger Pau Monne wrote: > > @@ -91,6 +91,21 @@ int x86_msr_copy_from_buffer(struct msr_policy *policy, > > const msr_entry_buffer_t msrs, uint32_t > > nr_entries, > >

Re: [PATCH v4 03/10] libx86: introduce helper to fetch msr entry

2021-05-17 Thread Jan Beulich
On 07.05.2021 13:04, Roger Pau Monne wrote: > @@ -91,6 +91,21 @@ int x86_msr_copy_from_buffer(struct msr_policy *policy, > const msr_entry_buffer_t msrs, uint32_t > nr_entries, > uint32_t *err_msr); > > +/** > + * Get a MSR entry from a

[PATCH v4 03/10] libx86: introduce helper to fetch msr entry

2021-05-07 Thread Roger Pau Monne
Use such helper in order to replace the code in x86_msr_copy_from_buffer. Note the introduced helper should not be directly called and instead x86_msr_get_entry should be used that will properly deal with const and non-const inputs. Note this requires making the raw fields uint64_t so that it can