Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-22 Thread Oleksandr Andrushchenko
On 22.11.21 16:57, Jan Beulich wrote: > On 22.11.2021 15:45, Oleksandr Andrushchenko wrote: >> >> On 22.11.21 16:37, Jan Beulich wrote: >>> On 22.11.2021 15:21, Oleksandr Andrushchenko wrote: On 19.11.21 15:34, Oleksandr Andrushchenko wrote: > On 19.11.21 15:25, Jan Beulich wrote: >>

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-22 Thread Jan Beulich
On 22.11.2021 15:45, Oleksandr Andrushchenko wrote: > > > On 22.11.21 16:37, Jan Beulich wrote: >> On 22.11.2021 15:21, Oleksandr Andrushchenko wrote: >>> On 19.11.21 15:34, Oleksandr Andrushchenko wrote: On 19.11.21 15:25, Jan Beulich wrote: > On 19.11.2021 14:16, Oleksandr Andrushchenk

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-22 Thread Oleksandr Andrushchenko
On 22.11.21 16:37, Jan Beulich wrote: > On 22.11.2021 15:21, Oleksandr Andrushchenko wrote: >> On 19.11.21 15:34, Oleksandr Andrushchenko wrote: >>> On 19.11.21 15:25, Jan Beulich wrote: On 19.11.2021 14:16, Oleksandr Andrushchenko wrote: > On 19.11.21 15:00, Jan Beulich wrote: >> On

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-22 Thread Jan Beulich
On 22.11.2021 15:21, Oleksandr Andrushchenko wrote: > On 19.11.21 15:34, Oleksandr Andrushchenko wrote: >> On 19.11.21 15:25, Jan Beulich wrote: >>> On 19.11.2021 14:16, Oleksandr Andrushchenko wrote: On 19.11.21 15:00, Jan Beulich wrote: > On 19.11.2021 13:34, Oleksandr Andrushchenko wrot

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-22 Thread Oleksandr Andrushchenko
On 19.11.21 15:34, Oleksandr Andrushchenko wrote: > > On 19.11.21 15:25, Jan Beulich wrote: >> On 19.11.2021 14:16, Oleksandr Andrushchenko wrote: >>> On 19.11.21 15:00, Jan Beulich wrote: On 19.11.2021 13:34, Oleksandr Andrushchenko wrote: > Possible locking and other work needed: >

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-19 Thread Oleksandr Andrushchenko
On 19.11.21 15:25, Jan Beulich wrote: > On 19.11.2021 14:16, Oleksandr Andrushchenko wrote: >> On 19.11.21 15:00, Jan Beulich wrote: >>> On 19.11.2021 13:34, Oleksandr Andrushchenko wrote: Possible locking and other work needed: === 1. pcide

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-19 Thread Jan Beulich
On 19.11.2021 14:16, Oleksandr Andrushchenko wrote: > On 19.11.21 15:00, Jan Beulich wrote: >> On 19.11.2021 13:34, Oleksandr Andrushchenko wrote: >>> Possible locking and other work needed: >>> === >>> >>> 1. pcidevs_{lock|unlock} is too heavy and is per-host >>

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-19 Thread Oleksandr Andrushchenko
On 19.11.21 15:00, Jan Beulich wrote: > On 19.11.2021 13:34, Oleksandr Andrushchenko wrote: >> Possible locking and other work needed: >> === >> >> 1. pcidevs_{lock|unlock} is too heavy and is per-host >> 2. pdev->vpci->lock cannot be used as vpci is freed by v

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-19 Thread Jan Beulich
On 19.11.2021 13:34, Oleksandr Andrushchenko wrote: > Possible locking and other work needed: > === > > 1. pcidevs_{lock|unlock} is too heavy and is per-host > 2. pdev->vpci->lock cannot be used as vpci is freed by vpci_remove_device > 3. We may want a dedicated

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-19 Thread Oleksandr Andrushchenko
Hi, Roger, Jan! On 18.11.21 17:53, Jan Beulich wrote: > On 18.11.2021 16:46, Oleksandr Andrushchenko wrote: >> On 18.11.21 17:41, Jan Beulich wrote: >>> On 18.11.2021 16:21, Oleksandr Andrushchenko wrote: On 18.11.21 17:16, Jan Beulich wrote: > For the moment I can't help thinking tha

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Jan Beulich
On 18.11.2021 16:46, Oleksandr Andrushchenko wrote: > On 18.11.21 17:41, Jan Beulich wrote: >> On 18.11.2021 16:21, Oleksandr Andrushchenko wrote: >>> On 18.11.21 17:16, Jan Beulich wrote: For the moment I can't help thinking that draining would be preferable over canceling. >>> Given

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Oleksandr Andrushchenko
On 18.11.21 17:41, Jan Beulich wrote: > On 18.11.2021 16:21, Oleksandr Andrushchenko wrote: >> On 18.11.21 17:16, Jan Beulich wrote: >>> On 18.11.2021 16:11, Oleksandr Andrushchenko wrote: On 18.11.21 16:35, Jan Beulich wrote: > On 18.11.2021 15:14, Oleksandr Andrushchenko wrote: >>

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Jan Beulich
On 18.11.2021 16:21, Oleksandr Andrushchenko wrote: > On 18.11.21 17:16, Jan Beulich wrote: >> On 18.11.2021 16:11, Oleksandr Andrushchenko wrote: >>> On 18.11.21 16:35, Jan Beulich wrote: On 18.11.2021 15:14, Oleksandr Andrushchenko wrote: > On 18.11.21 16:04, Roger Pau Monné wrote: >

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Oleksandr Andrushchenko
On 18.11.21 17:16, Jan Beulich wrote: > On 18.11.2021 16:11, Oleksandr Andrushchenko wrote: >> >> On 18.11.21 16:35, Jan Beulich wrote: >>> On 18.11.2021 15:14, Oleksandr Andrushchenko wrote: On 18.11.21 16:04, Roger Pau Monné wrote: > Indeed. In the physdevop failure case this comes fro

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Jan Beulich
On 18.11.2021 16:11, Oleksandr Andrushchenko wrote: > > > On 18.11.21 16:35, Jan Beulich wrote: >> On 18.11.2021 15:14, Oleksandr Andrushchenko wrote: >>> On 18.11.21 16:04, Roger Pau Monné wrote: Indeed. In the physdevop failure case this comes from an hypercall context, so maybe you c

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Oleksandr Andrushchenko
On 18.11.21 16:35, Jan Beulich wrote: > On 18.11.2021 15:14, Oleksandr Andrushchenko wrote: >> On 18.11.21 16:04, Roger Pau Monné wrote: >>> Indeed. In the physdevop failure case this comes from an hypercall >>> context, so maybe you could do the mapping in place using hypercall >>> continuations

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Jan Beulich
On 18.11.2021 15:14, Oleksandr Andrushchenko wrote: > On 18.11.21 16:04, Roger Pau Monné wrote: >> Indeed. In the physdevop failure case this comes from an hypercall >> context, so maybe you could do the mapping in place using hypercall >> continuations if required. Not sure how complex that would

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Oleksandr Andrushchenko
On 18.11.21 16:04, Roger Pau Monné wrote: > Sorry, I've been quite busy with other staff. > > On Thu, Nov 18, 2021 at 01:48:06PM +, Oleksandr Andrushchenko wrote: >> >> On 18.11.21 15:25, Jan Beulich wrote: >>> On 18.11.2021 10:32, Oleksandr Andrushchenko wrote: On 18.11.21 11:15, Jan Be

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Roger Pau Monné
Sorry, I've been quite busy with other staff. On Thu, Nov 18, 2021 at 01:48:06PM +, Oleksandr Andrushchenko wrote: > > > On 18.11.21 15:25, Jan Beulich wrote: > > On 18.11.2021 10:32, Oleksandr Andrushchenko wrote: > >> > >> On 18.11.21 11:15, Jan Beulich wrote: > >>> On 18.11.2021 09:54, Ol

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Oleksandr Andrushchenko
On 18.11.21 15:25, Jan Beulich wrote: > On 18.11.2021 10:32, Oleksandr Andrushchenko wrote: >> >> On 18.11.21 11:15, Jan Beulich wrote: >>> On 18.11.2021 09:54, Oleksandr Andrushchenko wrote: On 18.11.21 10:36, Jan Beulich wrote: > On 18.11.2021 08:49, Oleksandr Andrushchenko wrote:

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Jan Beulich
On 18.11.2021 10:32, Oleksandr Andrushchenko wrote: > > > On 18.11.21 11:15, Jan Beulich wrote: >> On 18.11.2021 09:54, Oleksandr Andrushchenko wrote: >>> On 18.11.21 10:36, Jan Beulich wrote: On 18.11.2021 08:49, Oleksandr Andrushchenko wrote: > On 17.11.21 10:28, Jan Beulich wrote: >>>

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Oleksandr Andrushchenko
Hi, Julien! On 16.11.21 20:02, Julien Grall wrote: > Hi Oleksandr, > > On 16/11/2021 14:24, Oleksandr Andrushchenko wrote: >> >> >> On 16.11.21 16:12, Jan Beulich wrote: >>> On 16.11.2021 14:41, Oleksandr Andrushchenko wrote: On 16.11.21 10:23, Oleksandr Andrushchenko wrote: > On 16.

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Oleksandr Andrushchenko
On 18.11.21 11:15, Jan Beulich wrote: > On 18.11.2021 09:54, Oleksandr Andrushchenko wrote: >> On 18.11.21 10:36, Jan Beulich wrote: >>> On 18.11.2021 08:49, Oleksandr Andrushchenko wrote: On 17.11.21 10:28, Jan Beulich wrote: > On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: >>

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Jan Beulich
On 18.11.2021 09:54, Oleksandr Andrushchenko wrote: > On 18.11.21 10:36, Jan Beulich wrote: >> On 18.11.2021 08:49, Oleksandr Andrushchenko wrote: >>> On 17.11.21 10:28, Jan Beulich wrote: On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > When

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Oleksandr Andrushchenko
On 18.11.21 10:36, Jan Beulich wrote: > On 18.11.2021 08:49, Oleksandr Andrushchenko wrote: >> >> On 17.11.21 10:28, Jan Beulich wrote: >>> On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko When a vPCI is removed for a PCI device it is possible that

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-18 Thread Jan Beulich
On 18.11.2021 08:49, Oleksandr Andrushchenko wrote: > > > On 17.11.21 10:28, Jan Beulich wrote: >> On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> When a vPCI is removed for a PCI device it is possible that we have >>> scheduled a delayed work for ma

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-17 Thread Oleksandr Andrushchenko
On 17.11.21 10:28, Jan Beulich wrote: > On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> When a vPCI is removed for a PCI device it is possible that we have >> scheduled a delayed work for map/unmap operations for that device. >> For example, the followi

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-17 Thread Jan Beulich
On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > When a vPCI is removed for a PCI device it is possible that we have > scheduled a delayed work for map/unmap operations for that device. > For example, the following scenario can illustrate the problem: > > p

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-16 Thread Julien Grall
Hi Oleksandr, On 16/11/2021 14:24, Oleksandr Andrushchenko wrote: On 16.11.21 16:12, Jan Beulich wrote: On 16.11.2021 14:41, Oleksandr Andrushchenko wrote: On 16.11.21 10:23, Oleksandr Andrushchenko wrote: On 16.11.21 10:01, Jan Beulich wrote: On 16.11.2021 08:32, Oleksandr Andrushchenko

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-16 Thread Jan Beulich
On 16.11.2021 15:24, Oleksandr Andrushchenko wrote: > > > On 16.11.21 16:12, Jan Beulich wrote: >> On 16.11.2021 14:41, Oleksandr Andrushchenko wrote: >>> >>> On 16.11.21 10:23, Oleksandr Andrushchenko wrote: On 16.11.21 10:01, Jan Beulich wrote: > On 16.11.2021 08:32, Oleksandr Andrushc

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-16 Thread Oleksandr Andrushchenko
On 16.11.21 16:24, Oleksandr Andrushchenko wrote: > > On 16.11.21 16:12, Jan Beulich wrote: >> On 16.11.2021 14:41, Oleksandr Andrushchenko wrote: >>> On 16.11.21 10:23, Oleksandr Andrushchenko wrote: On 16.11.21 10:01, Jan Beulich wrote: > On 16.11.2021 08:32, Oleksandr Andrushchenko wr

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-16 Thread Oleksandr Andrushchenko
On 16.11.21 16:12, Jan Beulich wrote: > On 16.11.2021 14:41, Oleksandr Andrushchenko wrote: >> >> On 16.11.21 10:23, Oleksandr Andrushchenko wrote: >>> On 16.11.21 10:01, Jan Beulich wrote: On 16.11.2021 08:32, Oleksandr Andrushchenko wrote: > On 15.11.21 18:56, Jan Beulich wrote: >>

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-16 Thread Jan Beulich
On 16.11.2021 14:41, Oleksandr Andrushchenko wrote: > > > On 16.11.21 10:23, Oleksandr Andrushchenko wrote: >> >> On 16.11.21 10:01, Jan Beulich wrote: >>> On 16.11.2021 08:32, Oleksandr Andrushchenko wrote: On 15.11.21 18:56, Jan Beulich wrote: > On 05.11.2021 07:56, Oleksandr Andrushch

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-16 Thread Jan Beulich
On 16.11.2021 14:27, Oleksandr Andrushchenko wrote: > > > On 16.11.21 13:38, Jan Beulich wrote: >> On 16.11.2021 09:23, Oleksandr Andrushchenko wrote: >>> >>> On 16.11.21 10:01, Jan Beulich wrote: On 16.11.2021 08:32, Oleksandr Andrushchenko wrote: > On 15.11.21 18:56, Jan Beulich wrote:

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-16 Thread Oleksandr Andrushchenko
On 16.11.21 10:23, Oleksandr Andrushchenko wrote: > > On 16.11.21 10:01, Jan Beulich wrote: >> On 16.11.2021 08:32, Oleksandr Andrushchenko wrote: >>> On 15.11.21 18:56, Jan Beulich wrote: On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Wh

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-16 Thread Oleksandr Andrushchenko
On 16.11.21 13:38, Jan Beulich wrote: > On 16.11.2021 09:23, Oleksandr Andrushchenko wrote: >> >> On 16.11.21 10:01, Jan Beulich wrote: >>> On 16.11.2021 08:32, Oleksandr Andrushchenko wrote: On 15.11.21 18:56, Jan Beulich wrote: > On 05.11.2021 07:56, Oleksandr Andrushchenko wrote:

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-16 Thread Jan Beulich
On 16.11.2021 09:23, Oleksandr Andrushchenko wrote: > > > On 16.11.21 10:01, Jan Beulich wrote: >> On 16.11.2021 08:32, Oleksandr Andrushchenko wrote: >>> On 15.11.21 18:56, Jan Beulich wrote: On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: > @@ -165,6 +164,18 @@ bool vpci_process_pe

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-16 Thread Oleksandr Andrushchenko
On 16.11.21 10:01, Jan Beulich wrote: > On 16.11.2021 08:32, Oleksandr Andrushchenko wrote: >> On 15.11.21 18:56, Jan Beulich wrote: >>> On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko When a vPCI is removed for a PCI device it is possible that we

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-16 Thread Jan Beulich
On 16.11.2021 08:32, Oleksandr Andrushchenko wrote: > On 15.11.21 18:56, Jan Beulich wrote: >> On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> When a vPCI is removed for a PCI device it is possible that we have >>> scheduled a delayed work for map/unma

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-15 Thread Oleksandr Andrushchenko
On 15.11.21 18:56, Jan Beulich wrote: > On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> When a vPCI is removed for a PCI device it is possible that we have >> scheduled a delayed work for map/unmap operations for that device. >> For example, the followi

Re: [PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-15 Thread Jan Beulich
On 05.11.2021 07:56, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > When a vPCI is removed for a PCI device it is possible that we have > scheduled a delayed work for map/unmap operations for that device. > For example, the following scenario can illustrate the problem: > > p

[PATCH v4 02/11] vpci: cancel pending map/unmap on vpci removal

2021-11-04 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko When a vPCI is removed for a PCI device it is possible that we have scheduled a delayed work for map/unmap operations for that device. For example, the following scenario can illustrate the problem: pci_physdev_op pci_add_device init_bars -> modify_bars ->