Re: [PATCH v4 01/17] perf: Protect perf_guest_cbs with RCU

2021-11-11 Thread Paolo Bonzini
On 11/11/21 11:47, Peter Zijlstra wrote: This technically could be RCU_INIT_POINTER but it's not worth a respin. There are dozens of other occurrences, and if somebody wanted they could use Coccinelle to fix all of them. I've been pushing the other way, trying to get rid of RCU_INIT_POINTER() si

Re: [PATCH v4 01/17] perf: Protect perf_guest_cbs with RCU

2021-11-11 Thread Peter Zijlstra
On Thu, Nov 11, 2021 at 08:26:58AM +0100, Paolo Bonzini wrote: > On 11/11/21 03:07, Sean Christopherson wrote: > > EXPORT_SYMBOL_GPL(perf_register_guest_info_callbacks); > > int perf_unregister_guest_info_callbacks(struct perf_guest_info_callbacks > > *cbs) > > { > > - perf_guest_cbs = NU

Re: [PATCH v4 01/17] perf: Protect perf_guest_cbs with RCU

2021-11-10 Thread Paolo Bonzini
On 11/11/21 03:07, Sean Christopherson wrote: Protect perf_guest_cbs with RCU to fix multiple possible errors. Luckily, all paths that read perf_guest_cbs already require RCU protection, e.g. to protect the callback chains, so only the direct perf_guest_cbs touchpoints need to be modified. Bug

[PATCH v4 01/17] perf: Protect perf_guest_cbs with RCU

2021-11-10 Thread Sean Christopherson
Protect perf_guest_cbs with RCU to fix multiple possible errors. Luckily, all paths that read perf_guest_cbs already require RCU protection, e.g. to protect the callback chains, so only the direct perf_guest_cbs touchpoints need to be modified. Bug #1 is a simple lack of WRITE_ONCE/READ_ONCE beha