Re: [PATCH v4] Avoid crash calling PrintErrMesg from efi_multiboot2

2024-11-15 Thread Jan Beulich
On 15.11.2024 11:27, Frediano Ziglio wrote: > On Thu, Nov 14, 2024 at 3:04 PM Jan Beulich wrote: >> >> On 14.11.2024 15:02, Frediano Ziglio wrote: >>> On Tue, Nov 5, 2024 at 2:52 PM Jan Beulich wrote: On 19.08.2024 16:29, Frediano Ziglio wrote: > --- a/xen/common/efi/boot.c > ++

Re: [PATCH v4] Avoid crash calling PrintErrMesg from efi_multiboot2

2024-11-15 Thread Frediano Ziglio
On Thu, Nov 14, 2024 at 3:04 PM Jan Beulich wrote: > > On 14.11.2024 15:02, Frediano Ziglio wrote: > > On Tue, Nov 5, 2024 at 2:52 PM Jan Beulich wrote: > >> > >> On 19.08.2024 16:29, Frediano Ziglio wrote: > >>> --- a/xen/common/efi/boot.c > >>> +++ b/xen/common/efi/boot.c > >>> @@ -287,19 +287,

Re: [PATCH v4] Avoid crash calling PrintErrMesg from efi_multiboot2

2024-11-14 Thread Jan Beulich
On 14.11.2024 15:02, Frediano Ziglio wrote: > On Tue, Nov 5, 2024 at 2:52 PM Jan Beulich wrote: >> >> On 19.08.2024 16:29, Frediano Ziglio wrote: >>> --- a/xen/common/efi/boot.c >>> +++ b/xen/common/efi/boot.c >>> @@ -287,19 +287,36 @@ static bool __init match_guid(const EFI_GUID *guid1, >>> cons

Re: [PATCH v4] Avoid crash calling PrintErrMesg from efi_multiboot2

2024-11-14 Thread Frediano Ziglio
On Tue, Nov 5, 2024 at 2:52 PM Jan Beulich wrote: > > On 19.08.2024 16:29, Frediano Ziglio wrote: > > --- a/xen/common/efi/boot.c > > +++ b/xen/common/efi/boot.c > > @@ -287,19 +287,36 @@ static bool __init match_guid(const EFI_GUID *guid1, > > const EFI_GUID *guid2) > > /* generic routine for p

Re: [PATCH v4] Avoid crash calling PrintErrMesg from efi_multiboot2

2024-11-05 Thread Jan Beulich
On 19.08.2024 16:29, Frediano Ziglio wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -287,19 +287,36 @@ static bool __init match_guid(const EFI_GUID *guid1, > const EFI_GUID *guid2) > /* generic routine for printing error messages */ > static void __init PrintErrMesg(cons

Re: [PATCH v4] Avoid crash calling PrintErrMesg from efi_multiboot2

2024-09-26 Thread Jan Beulich
On 26.09.2024 16:11, Andrew Cooper wrote: > On 26/09/2024 2:26 pm, Marek Marczykowski-Górecki wrote: >> On Mon, Aug 19, 2024 at 03:29:52PM +0100, Frediano Ziglio wrote: >>> Although code is compiled with -fpic option data is not position >>> independent. This causes data pointer to become invalid i

Re: [PATCH v4] Avoid crash calling PrintErrMesg from efi_multiboot2

2024-09-26 Thread Andrew Cooper
On 26/09/2024 2:26 pm, Marek Marczykowski-Górecki wrote: > On Mon, Aug 19, 2024 at 03:29:52PM +0100, Frediano Ziglio wrote: >> Although code is compiled with -fpic option data is not position >> independent. This causes data pointer to become invalid if >> code is not relocated properly which is wh

Re: [PATCH v4] Avoid crash calling PrintErrMesg from efi_multiboot2

2024-09-26 Thread Marek Marczykowski-Górecki
On Mon, Aug 19, 2024 at 03:29:52PM +0100, Frediano Ziglio wrote: > Although code is compiled with -fpic option data is not position > independent. This causes data pointer to become invalid if > code is not relocated properly which is what happens for > efi_multiboot2 which is called by multiboot e

Re: [PATCH v4] Avoid crash calling PrintErrMesg from efi_multiboot2

2024-09-11 Thread Frediano Ziglio
On Thu, Aug 29, 2024 at 10:03 AM Frediano Ziglio wrote: > On Mon, Aug 19, 2024 at 3:30 PM Frediano Ziglio > wrote: > > > > Although code is compiled with -fpic option data is not position > > independent. This causes data pointer to become invalid if > > code is not relocated properly which is w

Re: [PATCH v4] Avoid crash calling PrintErrMesg from efi_multiboot2

2024-08-29 Thread Frediano Ziglio
On Mon, Aug 19, 2024 at 3:30 PM Frediano Ziglio wrote: > > Although code is compiled with -fpic option data is not position > independent. This causes data pointer to become invalid if > code is not relocated properly which is what happens for > efi_multiboot2 which is called by multiboot entry co

[PATCH v4] Avoid crash calling PrintErrMesg from efi_multiboot2

2024-08-19 Thread Frediano Ziglio
Although code is compiled with -fpic option data is not position independent. This causes data pointer to become invalid if code is not relocated properly which is what happens for efi_multiboot2 which is called by multiboot entry code. Code tested adding PrintErrMesg(L"Test message", EFI_BUFFE