Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-23 Thread Tamas K Lengyel
On Wed, Dec 23, 2020 at 9:44 AM Julien Grall wrote: > > > > On 23/12/2020 13:41, Jan Beulich wrote: > > On 23.12.2020 14:33, Julien Grall wrote: > >> On 23/12/2020 13:12, Jan Beulich wrote: > >>> From the input by both of you I still can't > >>> conclude whether this patch should remain as is in

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-23 Thread Julien Grall
Hi Jan, On 23/12/2020 14:56, Jan Beulich wrote: On 23.12.2020 15:44, Julien Grall wrote: On 23/12/2020 13:41, Jan Beulich wrote: On 23.12.2020 14:33, Julien Grall wrote: On 23/12/2020 13:12, Jan Beulich wrote: From the input by both of you I still can't conclude whether this patch should r

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-23 Thread Jan Beulich
On 23.12.2020 15:44, Julien Grall wrote: > On 23/12/2020 13:41, Jan Beulich wrote: >> On 23.12.2020 14:33, Julien Grall wrote: >>> On 23/12/2020 13:12, Jan Beulich wrote: From the input by both of you I still can't conclude whether this patch should remain as is in v4, or revert bac

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-23 Thread Julien Grall
On 23/12/2020 13:41, Jan Beulich wrote: On 23.12.2020 14:33, Julien Grall wrote: On 23/12/2020 13:12, Jan Beulich wrote: From the input by both of you I still can't conclude whether this patch should remain as is in v4, or revert back to its v2 version. Please can we get this settled so I c

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-23 Thread Jan Beulich
On 23.12.2020 14:33, Julien Grall wrote: > On 23/12/2020 13:12, Jan Beulich wrote: >> From the input by both of you I still can't >> conclude whether this patch should remain as is in v4, or revert >> back to its v2 version. Please can we get this settled so I can get >> v4 out? > > I haven't had

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-23 Thread Julien Grall
On 23/12/2020 13:12, Jan Beulich wrote: On 07.12.2020 18:35, Tamas K Lengyel wrote: On Mon, Dec 7, 2020 at 12:30 PM Julien Grall wrote: Hi Jan, On 07/12/2020 15:28, Jan Beulich wrote: On 04.12.2020 20:15, Tamas K Lengyel wrote: On Fri, Dec 4, 2020 at 10:29 AM Julien Grall wrote: On 04

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-23 Thread Jan Beulich
On 07.12.2020 18:35, Tamas K Lengyel wrote: > On Mon, Dec 7, 2020 at 12:30 PM Julien Grall wrote: >> >> Hi Jan, >> >> On 07/12/2020 15:28, Jan Beulich wrote: >>> On 04.12.2020 20:15, Tamas K Lengyel wrote: On Fri, Dec 4, 2020 at 10:29 AM Julien Grall wrote: > On 04/12/2020 15:21, Tamas K

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-07 Thread Tamas K Lengyel
On Mon, Dec 7, 2020 at 12:30 PM Julien Grall wrote: > > Hi Jan, > > On 07/12/2020 15:28, Jan Beulich wrote: > > On 04.12.2020 20:15, Tamas K Lengyel wrote: > >> On Fri, Dec 4, 2020 at 10:29 AM Julien Grall wrote: > >>> On 04/12/2020 15:21, Tamas K Lengyel wrote: > On Fri, Dec 4, 2020 at 6:29

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-07 Thread Julien Grall
Hi Jan, On 07/12/2020 15:28, Jan Beulich wrote: On 04.12.2020 20:15, Tamas K Lengyel wrote: On Fri, Dec 4, 2020 at 10:29 AM Julien Grall wrote: On 04/12/2020 15:21, Tamas K Lengyel wrote: On Fri, Dec 4, 2020 at 6:29 AM Julien Grall wrote: On 03/12/2020 10:09, Jan Beulich wrote: On 02.12.2

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-07 Thread Julien Grall
On 07/12/2020 08:02, Jan Beulich wrote: On 04.12.2020 16:09, Julien Grall wrote: On 04/12/2020 12:01, Jan Beulich wrote: On 04.12.2020 12:51, Julien Grall wrote: On 04/12/2020 11:48, Jan Beulich wrote: On 04.12.2020 12:28, Julien Grall wrote: On 03/12/2020 10:09, Jan Beulich wrote: On 02

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-07 Thread Jan Beulich
On 04.12.2020 20:15, Tamas K Lengyel wrote: > On Fri, Dec 4, 2020 at 10:29 AM Julien Grall wrote: >> On 04/12/2020 15:21, Tamas K Lengyel wrote: >>> On Fri, Dec 4, 2020 at 6:29 AM Julien Grall wrote: On 03/12/2020 10:09, Jan Beulich wrote: > On 02.12.2020 22:10, Julien Grall wrote: >

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-07 Thread Jan Beulich
On 04.12.2020 16:09, Julien Grall wrote: > On 04/12/2020 12:01, Jan Beulich wrote: >> On 04.12.2020 12:51, Julien Grall wrote: >>> On 04/12/2020 11:48, Jan Beulich wrote: On 04.12.2020 12:28, Julien Grall wrote: > On 03/12/2020 10:09, Jan Beulich wrote: >> On 02.12.2020 22:10, Julien G

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-04 Thread Tamas K Lengyel
On Fri, Dec 4, 2020 at 2:22 PM Julien Grall wrote: > > On Fri, 4 Dec 2020 at 19:15, Tamas K Lengyel > wrote: > > > > On Fri, Dec 4, 2020 at 10:29 AM Julien Grall wrote: > > > > > > > > > > > > On 04/12/2020 15:21, Tamas K Lengyel wrote: > > > > On Fri, Dec 4, 2020 at 6:29 AM Julien Grall wrote

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-04 Thread Julien Grall
On Fri, 4 Dec 2020 at 19:15, Tamas K Lengyel wrote: > > On Fri, Dec 4, 2020 at 10:29 AM Julien Grall wrote: > > > > > > > > On 04/12/2020 15:21, Tamas K Lengyel wrote: > > > On Fri, Dec 4, 2020 at 6:29 AM Julien Grall wrote: > > >> > > >> Hi Jan, > > >> > > >> On 03/12/2020 10:09, Jan Beulich wr

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-04 Thread Tamas K Lengyel
On Fri, Dec 4, 2020 at 10:29 AM Julien Grall wrote: > > > > On 04/12/2020 15:21, Tamas K Lengyel wrote: > > On Fri, Dec 4, 2020 at 6:29 AM Julien Grall wrote: > >> > >> Hi Jan, > >> > >> On 03/12/2020 10:09, Jan Beulich wrote: > >>> On 02.12.2020 22:10, Julien Grall wrote: > On 23/11/2020 13

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-04 Thread Julien Grall
On 04/12/2020 15:21, Tamas K Lengyel wrote: On Fri, Dec 4, 2020 at 6:29 AM Julien Grall wrote: Hi Jan, On 03/12/2020 10:09, Jan Beulich wrote: On 02.12.2020 22:10, Julien Grall wrote: On 23/11/2020 13:30, Jan Beulich wrote: While there don't look to be any problems with this right now,

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-04 Thread Tamas K Lengyel
On Fri, Dec 4, 2020 at 6:29 AM Julien Grall wrote: > > Hi Jan, > > On 03/12/2020 10:09, Jan Beulich wrote: > > On 02.12.2020 22:10, Julien Grall wrote: > >> On 23/11/2020 13:30, Jan Beulich wrote: > >>> While there don't look to be any problems with this right now, the lock > >>> order implication

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-04 Thread Julien Grall
Hi, On 04/12/2020 12:01, Jan Beulich wrote: On 04.12.2020 12:51, Julien Grall wrote: On 04/12/2020 11:48, Jan Beulich wrote: On 04.12.2020 12:28, Julien Grall wrote: Hi Jan, On 03/12/2020 10:09, Jan Beulich wrote: On 02.12.2020 22:10, Julien Grall wrote: On 23/11/2020 13:30, Jan Beulich

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-04 Thread Jan Beulich
On 04.12.2020 12:51, Julien Grall wrote: > > > On 04/12/2020 11:48, Jan Beulich wrote: >> On 04.12.2020 12:28, Julien Grall wrote: >>> Hi Jan, >>> >>> On 03/12/2020 10:09, Jan Beulich wrote: On 02.12.2020 22:10, Julien Grall wrote: > On 23/11/2020 13:30, Jan Beulich wrote: >> While t

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-04 Thread Julien Grall
On 04/12/2020 11:48, Jan Beulich wrote: On 04.12.2020 12:28, Julien Grall wrote: Hi Jan, On 03/12/2020 10:09, Jan Beulich wrote: On 02.12.2020 22:10, Julien Grall wrote: On 23/11/2020 13:30, Jan Beulich wrote: While there don't look to be any problems with this right now, the lock order i

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-04 Thread Jan Beulich
On 04.12.2020 12:28, Julien Grall wrote: > Hi Jan, > > On 03/12/2020 10:09, Jan Beulich wrote: >> On 02.12.2020 22:10, Julien Grall wrote: >>> On 23/11/2020 13:30, Jan Beulich wrote: While there don't look to be any problems with this right now, the lock order implications from holding t

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-04 Thread Julien Grall
Hi Jan, On 03/12/2020 10:09, Jan Beulich wrote: On 02.12.2020 22:10, Julien Grall wrote: On 23/11/2020 13:30, Jan Beulich wrote: While there don't look to be any problems with this right now, the lock order implications from holding the lock can be very difficult to follow (and may be easy to

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-03 Thread Tamas K Lengyel
On Thu, Dec 3, 2020 at 5:09 AM Jan Beulich wrote: > > On 02.12.2020 22:10, Julien Grall wrote: > > On 23/11/2020 13:30, Jan Beulich wrote: > >> While there don't look to be any problems with this right now, the lock > >> order implications from holding the lock can be very difficult to follow > >>

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-03 Thread Jan Beulich
On 02.12.2020 22:10, Julien Grall wrote: > On 23/11/2020 13:30, Jan Beulich wrote: >> While there don't look to be any problems with this right now, the lock >> order implications from holding the lock can be very difficult to follow >> (and may be easy to violate unknowingly). The present callback

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-12-02 Thread Julien Grall
Hi Jan, On 23/11/2020 13:30, Jan Beulich wrote: While there don't look to be any problems with this right now, the lock order implications from holding the lock can be very difficult to follow (and may be easy to violate unknowingly). The present callbacks don't (and no such callback should) hav

Re: [PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-11-30 Thread Isaila Alexandru
On 23.11.2020 15:30, Jan Beulich wrote: While there don't look to be any problems with this right now, the lock order implications from holding the lock can be very difficult to follow (and may be easy to violate unknowingly). The present callbacks don't (and no such callback should) have any nee

[PATCH v3 5/5] evtchn: don't call Xen consumer callback with per-channel lock held

2020-11-23 Thread Jan Beulich
While there don't look to be any problems with this right now, the lock order implications from holding the lock can be very difficult to follow (and may be easy to violate unknowingly). The present callbacks don't (and no such callback should) have any need for the lock to be held. However, vm_ev