Re: [PATCH v3 3/4] x86/APIC: skip unnecessary parts of __setup_APIC_LVTT()

2022-03-14 Thread Roger Pau Monné
On Mon, Mar 14, 2022 at 09:25:07AM +0100, Jan Beulich wrote: > On 11.03.2022 15:05, Roger Pau Monné wrote: > > On Mon, Feb 14, 2022 at 10:25:31AM +0100, Jan Beulich wrote: > >> In TDT mode there's no point writing TDCR or TMICT, while outside of > >> that mode there's no need for the MFENCE. > >> >

Re: [PATCH v3 3/4] x86/APIC: skip unnecessary parts of __setup_APIC_LVTT()

2022-03-14 Thread Jan Beulich
On 11.03.2022 15:05, Roger Pau Monné wrote: > On Mon, Feb 14, 2022 at 10:25:31AM +0100, Jan Beulich wrote: >> In TDT mode there's no point writing TDCR or TMICT, while outside of >> that mode there's no need for the MFENCE. >> >> No change intended to overall functioning. >> >> Signed-off-by: Jan B

Re: [PATCH v3 3/4] x86/APIC: skip unnecessary parts of __setup_APIC_LVTT()

2022-03-11 Thread Roger Pau Monné
On Mon, Feb 14, 2022 at 10:25:31AM +0100, Jan Beulich wrote: > In TDT mode there's no point writing TDCR or TMICT, while outside of > that mode there's no need for the MFENCE. > > No change intended to overall functioning. > > Signed-off-by: Jan Beulich I've got some comments below, now that th

[PATCH v3 3/4] x86/APIC: skip unnecessary parts of __setup_APIC_LVTT()

2022-02-14 Thread Jan Beulich
In TDT mode there's no point writing TDCR or TMICT, while outside of that mode there's no need for the MFENCE. No change intended to overall functioning. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/apic.c +++ b/xen/arch/x86/apic.c @@ -1059,24 +1059,25 @@ static void __setup_APIC_