Re: [PATCH v3 2/3] xen/ppc: Implement early serial printk on pseries

2023-07-17 Thread Jan Beulich
On 17.07.2023 20:40, Shawn Anastasio wrote: > Quick followup, > > On 7/17/23 1:32 PM, Shawn Anastasio wrote: >> On 7/17/23 11:17 AM, Jan Beulich wrote: >>> This could do with using ARRAY_SIZE(rets). Same again below. >> >> Sure, will do this. > > ARRAY_SIZE is defined in which can't yet be inclu

Re: [PATCH v3 2/3] xen/ppc: Implement early serial printk on pseries

2023-07-17 Thread Jan Beulich
On 17.07.2023 20:32, Shawn Anastasio wrote: > On 7/17/23 11:17 AM, Jan Beulich wrote: >> On 06.07.2023 21:04, Shawn Anastasio wrote: >>> --- /dev/null >>> +++ b/xen/arch/ppc/boot-of.c >>> @@ -0,0 +1,100 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >>> +/* >>> + * Copyright IBM Corp. 2005

Re: [PATCH v3 2/3] xen/ppc: Implement early serial printk on pseries

2023-07-17 Thread Shawn Anastasio
Quick followup, On 7/17/23 1:32 PM, Shawn Anastasio wrote: > On 7/17/23 11:17 AM, Jan Beulich wrote: >> This could do with using ARRAY_SIZE(rets). Same again below. > > Sure, will do this. ARRAY_SIZE is defined in which can't yet be included due to missing headers. I could copy its definition i

Re: [PATCH v3 2/3] xen/ppc: Implement early serial printk on pseries

2023-07-17 Thread Shawn Anastasio
On 7/17/23 11:17 AM, Jan Beulich wrote: > On 06.07.2023 21:04, Shawn Anastasio wrote: >> --- a/xen/arch/ppc/Makefile >> +++ b/xen/arch/ppc/Makefile >> @@ -1,5 +1,7 @@ >> obj-$(CONFIG_PPC64) += ppc64/ >> >> +obj-y += boot-of.init.o >> +obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > > While in th

Re: [PATCH v3 2/3] xen/ppc: Implement early serial printk on pseries

2023-07-17 Thread Jan Beulich
On 06.07.2023 21:04, Shawn Anastasio wrote: > --- a/xen/arch/ppc/Makefile > +++ b/xen/arch/ppc/Makefile > @@ -1,5 +1,7 @@ > obj-$(CONFIG_PPC64) += ppc64/ > > +obj-y += boot-of.init.o > +obj-$(CONFIG_EARLY_PRINTK) += early_printk.o While in this case I could accept the name as is to be the same

[PATCH v3 2/3] xen/ppc: Implement early serial printk on pseries

2023-07-06 Thread Shawn Anastasio
On typical Power VMs (e.g. QEMU's -M pseries), a variety of services including an early serial console are provided by Open Firmware. Implement the required interfaces to call into Open Firmware and write to the serial console. Since Open Firmware runs in 32-bit Big Endian mode and Xen runs in 64-