Re: [PATCH v3 2/2] xl: Add escape character argument to xl console

2023-07-12 Thread Peter Hoyes
Thanks for the feedback. On 10/07/2023 15:43, Anthony PERARD wrote: On Thu, Jun 22, 2023 at 03:12:48PM +0100, Peter Hoyes wrote: /* libxl_primary_console_exec finds the domid and console number * corresponding to the primary console of the given vm, then calls * libxl_console_exec with

Re: [PATCH v3 2/2] xl: Add escape character argument to xl console

2023-07-10 Thread Anthony PERARD
On Thu, Jun 22, 2023 at 03:12:48PM +0100, Peter Hoyes wrote: > diff --git a/tools/include/libxl.h b/tools/include/libxl.h > index cac641a7eb..c513c39483 100644 > --- a/tools/include/libxl.h > +++ b/tools/include/libxl.h > @@ -1958,7 +1958,8 @@ int libxl_vncviewer_exec(libxl_ctx *ctx, uint32_t > do

[PATCH v3 2/2] xl: Add escape character argument to xl console

2023-06-22 Thread Peter Hoyes
From: Peter Hoyes Add -e argument to xl console and pass to new escape_character argument of libxl_console_exec. In libxl_console_exec, there are currently two call sites to execl, which uses varargs, in order to support optionally passing 'start-notify-fd' to the console client. In order to sup