Re: [PATCH v3 1/5] build: make cc-option properly deal with unrecognized sub-options

2023-08-22 Thread Anthony PERARD
On Wed, Aug 16, 2023 at 08:06:52AM +0200, Jan Beulich wrote: > On 11.08.2023 15:48, Anthony PERARD wrote: > > But isn't it doing doing pattern matching on an error message going to > > lead sometime to false positive? Linux's build system seems to works > > fine by just using the exit value. They'v

Re: [PATCH v3 1/5] build: make cc-option properly deal with unrecognized sub-options

2023-08-15 Thread Jan Beulich
On 11.08.2023 15:48, Anthony PERARD wrote: > On Wed, Jul 26, 2023 at 12:33:07PM +0200, Jan Beulich wrote: >> In options like -march=, it may be only the sub-option which is >> unrecognized by the compiler. In such an event the error message often >> splits option and argument, typically saying some

Re: [PATCH v3 1/5] build: make cc-option properly deal with unrecognized sub-options

2023-08-14 Thread Jan Beulich
On 14.08.2023 09:01, Jan Beulich wrote: > On 11.08.2023 15:48, Anthony PERARD wrote: >> On Wed, Jul 26, 2023 at 12:33:07PM +0200, Jan Beulich wrote: >>> In options like -march=, it may be only the sub-option which is >>> unrecognized by the compiler. In such an event the error message often >>> spl

Re: [PATCH v3 1/5] build: make cc-option properly deal with unrecognized sub-options

2023-08-14 Thread Jan Beulich
On 11.08.2023 15:48, Anthony PERARD wrote: > On Wed, Jul 26, 2023 at 12:33:07PM +0200, Jan Beulich wrote: >> In options like -march=, it may be only the sub-option which is >> unrecognized by the compiler. In such an event the error message often >> splits option and argument, typically saying some

Re: [PATCH v3 1/5] build: make cc-option properly deal with unrecognized sub-options

2023-08-11 Thread Anthony PERARD
On Wed, Jul 26, 2023 at 12:33:07PM +0200, Jan Beulich wrote: > In options like -march=, it may be only the sub-option which is > unrecognized by the compiler. In such an event the error message often > splits option and argument, typically saying something like "bad value > '' for ''. Extend the gr

[PATCH v3 1/5] build: make cc-option properly deal with unrecognized sub-options

2023-07-26 Thread Jan Beulich
In options like -march=, it may be only the sub-option which is unrecognized by the compiler. In such an event the error message often splits option and argument, typically saying something like "bad value '' for ''. Extend the grep invocation accordingly, also accounting for Clang to not mention e