Re: [PATCH v3 05/11] x86/vioapic: switch to use the EOI callback mechanism

2021-04-08 Thread Jan Beulich
On 08.04.2021 10:59, Roger Pau Monné wrote: > On Thu, Apr 08, 2021 at 08:27:10AM +0200, Jan Beulich wrote: >> On 07.04.2021 18:46, Roger Pau Monné wrote: >>> On Wed, Apr 07, 2021 at 05:19:06PM +0200, Jan Beulich wrote: On 31.03.2021 12:32, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/vi

Re: [PATCH v3 05/11] x86/vioapic: switch to use the EOI callback mechanism

2021-04-08 Thread Roger Pau Monné
On Thu, Apr 08, 2021 at 08:27:10AM +0200, Jan Beulich wrote: > On 07.04.2021 18:46, Roger Pau Monné wrote: > > On Wed, Apr 07, 2021 at 05:19:06PM +0200, Jan Beulich wrote: > >> On 31.03.2021 12:32, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/hvm/vioapic.c > >>> +++ b/xen/arch/x86/hvm/vioapic.c

Re: [PATCH v3 05/11] x86/vioapic: switch to use the EOI callback mechanism

2021-04-07 Thread Jan Beulich
On 07.04.2021 18:46, Roger Pau Monné wrote: > On Wed, Apr 07, 2021 at 05:19:06PM +0200, Jan Beulich wrote: >> On 31.03.2021 12:32, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/hvm/vioapic.c >>> +++ b/xen/arch/x86/hvm/vioapic.c >>> @@ -621,7 +624,43 @@ static int ioapic_load(struct domain *d, >>>

Re: [PATCH v3 05/11] x86/vioapic: switch to use the EOI callback mechanism

2021-04-07 Thread Roger Pau Monné
On Wed, Apr 07, 2021 at 05:19:06PM +0200, Jan Beulich wrote: > On 31.03.2021 12:32, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/vioapic.c > > +++ b/xen/arch/x86/hvm/vioapic.c > > @@ -621,7 +624,43 @@ static int ioapic_load(struct domain *d, > > hvm_domain_context_t *h) > > d->arch.

Re: [PATCH v3 05/11] x86/vioapic: switch to use the EOI callback mechanism

2021-04-07 Thread Jan Beulich
On 31.03.2021 12:32, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/vioapic.c > +++ b/xen/arch/x86/hvm/vioapic.c > @@ -394,6 +394,50 @@ static const struct hvm_mmio_ops vioapic_mmio_ops = { > .write = vioapic_write > }; > > +static void eoi_callback(unsigned int vector, void *data) > +{ >

[PATCH v3 05/11] x86/vioapic: switch to use the EOI callback mechanism

2021-03-31 Thread Roger Pau Monne
Switch the emulated IO-APIC code to use the local APIC EOI callback mechanism. This allows to remove the last hardcoded callback from vlapic_handle_EOI. Removing the hardcoded vIO-APIC callback also allows to getting rid of setting the EOI exit bitmap based on the triggering mode, as now all users