Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks

2021-04-07 Thread Jan Beulich
On 07.04.2021 09:41, Roger Pau Monné wrote: > On Thu, Apr 01, 2021 at 01:06:35PM +0200, Jan Beulich wrote: >> On 31.03.2021 12:32, Roger Pau Monne wrote: >>> EOIs are always executed in guest vCPU context, so there's no reason to >>> pass a vCPU parameter around as can be fetched from current. >> >

Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks

2021-04-07 Thread Roger Pau Monné
On Thu, Apr 01, 2021 at 01:06:35PM +0200, Jan Beulich wrote: > On 31.03.2021 12:32, Roger Pau Monne wrote: > > EOIs are always executed in guest vCPU context, so there's no reason to > > pass a vCPU parameter around as can be fetched from current. > > While not overly problematic, I'd like to poin

Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks

2021-04-01 Thread Jan Beulich
On 31.03.2021 12:32, Roger Pau Monne wrote: > EOIs are always executed in guest vCPU context, so there's no reason to > pass a vCPU parameter around as can be fetched from current. While not overly problematic, I'd like to point out that there's not a single vcpu parameter being dropped here - in

Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks

2021-04-01 Thread Roger Pau Monné
On Wed, Mar 31, 2021 at 05:24:24PM +0100, Andrew Cooper wrote: > On 31/03/2021 17:02, Jan Beulich wrote: > > On 31.03.2021 12:32, Roger Pau Monne wrote: > >> EOIs are always executed in guest vCPU context, so there's no reason to > >> pass a vCPU parameter around as can be fetched from current. > >

Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks

2021-03-31 Thread Andrew Cooper
On 31/03/2021 17:02, Jan Beulich wrote: > On 31.03.2021 12:32, Roger Pau Monne wrote: >> EOIs are always executed in guest vCPU context, so there's no reason to >> pass a vCPU parameter around as can be fetched from current. >> >> While there make the vector parameter of both callbacks unsigned int

Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks

2021-03-31 Thread Jan Beulich
On 31.03.2021 12:32, Roger Pau Monne wrote: > EOIs are always executed in guest vCPU context, so there's no reason to > pass a vCPU parameter around as can be fetched from current. > > While there make the vector parameter of both callbacks unsigned int. > > No functional change intended. > > Su

[PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks

2021-03-31 Thread Roger Pau Monne
EOIs are always executed in guest vCPU context, so there's no reason to pass a vCPU parameter around as can be fetched from current. While there make the vector parameter of both callbacks unsigned int. No functional change intended. Suggested-by: Paul Durrant Signed-off-by: Roger Pau Monné Re