Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2023-10-16 Thread Roger Pau Monné
On Mon, Oct 16, 2023 at 03:04:36PM +0200, Marek Marczykowski-Górecki wrote: > On Mon, Oct 16, 2023 at 11:05:10AM +0200, Roger Pau Monné wrote: > > On Fri, Nov 18, 2022 at 04:49:23PM +0100, Marek Marczykowski-Górecki wrote: > > > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked unti

Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2023-10-16 Thread Marek Marczykowski-Górecki
On Mon, Oct 16, 2023 at 11:05:10AM +0200, Roger Pau Monné wrote: > On Fri, Nov 18, 2022 at 04:49:23PM +0100, Marek Marczykowski-Górecki wrote: > > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > > the table is filled. Then it disables INTx just before clearing MASKALL > >

Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2023-10-16 Thread Roger Pau Monné
On Fri, Nov 18, 2022 at 04:49:23PM +0100, Marek Marczykowski-Górecki wrote: > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > the table is filled. Then it disables INTx just before clearing MASKALL > bit. Currently this approach is rejected by xen-pciback. > According to t

Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2023-10-15 Thread Juergen Gross
On 18.11.22 16:49, Marek Marczykowski-Górecki wrote: Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until the table is filled. Then it disables INTx just before clearing MASKALL bit. Currently this approach is rejected by xen-pciback. According to the PCIe spec, device cannot u

Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2023-09-27 Thread Marek Marczykowski-Górecki
On Fri, Nov 18, 2022 at 04:49:23PM +0100, Marek Marczykowski-Górecki wrote: > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > the table is filled. Then it disables INTx just before clearing MASKALL > bit. Currently this approach is rejected by xen-pciback. > According to t

Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2022-11-30 Thread Jason Andryuk
On Mon, Nov 28, 2022 at 8:44 AM Marek Marczykowski-Górecki wrote: > > On Mon, Nov 21, 2022 at 05:16:37PM +0100, Marek Marczykowski-Górecki wrote: > > On Mon, Nov 21, 2022 at 10:41:34AM -0500, Jason Andryuk wrote: > > > On Sat, Nov 19, 2022 at 11:33 AM Marek Marczykowski-Górecki > > > wrote: > > >

Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2022-11-28 Thread Marek Marczykowski-Górecki
On Mon, Nov 21, 2022 at 05:16:37PM +0100, Marek Marczykowski-Górecki wrote: > On Mon, Nov 21, 2022 at 10:41:34AM -0500, Jason Andryuk wrote: > > On Sat, Nov 19, 2022 at 11:33 AM Marek Marczykowski-Górecki > > wrote: > > > > > > On Sat, Nov 19, 2022 at 09:36:54AM -0500, Jason Andryuk wrote: > > > >

Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2022-11-21 Thread Marek Marczykowski-Górecki
On Mon, Nov 21, 2022 at 10:41:34AM -0500, Jason Andryuk wrote: > On Sat, Nov 19, 2022 at 11:33 AM Marek Marczykowski-Górecki > wrote: > > > > On Sat, Nov 19, 2022 at 09:36:54AM -0500, Jason Andryuk wrote: > > > Hi, Marek, > > > > > > On Fri, Nov 18, 2022 at 4:46 PM Marek Marczykowski-Górecki > > >

Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2022-11-21 Thread Jason Andryuk
On Sat, Nov 19, 2022 at 11:33 AM Marek Marczykowski-Górecki wrote: > > On Sat, Nov 19, 2022 at 09:36:54AM -0500, Jason Andryuk wrote: > > Hi, Marek, > > > > On Fri, Nov 18, 2022 at 4:46 PM Marek Marczykowski-Górecki > > wrote: > > > > > > On Fri, Nov 18, 2022 at 03:46:47PM -0500, Jason Andryuk wr

Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2022-11-19 Thread Marek Marczykowski-Górecki
On Sat, Nov 19, 2022 at 09:36:54AM -0500, Jason Andryuk wrote: > Hi, Marek, > > On Fri, Nov 18, 2022 at 4:46 PM Marek Marczykowski-Górecki > wrote: > > > > On Fri, Nov 18, 2022 at 03:46:47PM -0500, Jason Andryuk wrote: > > > I was trying to test your xen-pciback v3 patch, and I am having > > > as

Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2022-11-19 Thread Jason Andryuk
Hi, Marek, On Fri, Nov 18, 2022 at 4:46 PM Marek Marczykowski-Górecki wrote: > > On Fri, Nov 18, 2022 at 03:46:47PM -0500, Jason Andryuk wrote: > > On Fri, Nov 18, 2022 at 10:50 AM Marek Marczykowski-Górecki > > wrote: > > > > > > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked

Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2022-11-18 Thread Marek Marczykowski-Górecki
On Fri, Nov 18, 2022 at 03:46:47PM -0500, Jason Andryuk wrote: > On Fri, Nov 18, 2022 at 10:50 AM Marek Marczykowski-Górecki > wrote: > > > > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > > the table is filled. Then it disables INTx just before clearing MASKALL > > bit.

Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2022-11-18 Thread Jason Andryuk
On Fri, Nov 18, 2022 at 10:50 AM Marek Marczykowski-Górecki wrote: > > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > the table is filled. Then it disables INTx just before clearing MASKALL > bit. Currently this approach is rejected by xen-pciback. > According to the PCI

[PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2022-11-18 Thread Marek Marczykowski-Górecki
Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until the table is filled. Then it disables INTx just before clearing MASKALL bit. Currently this approach is rejected by xen-pciback. According to the PCIe spec, device cannot use INTx when MSI/MSI-X is enabled (in other words: enab