Re: [PATCH v3] xen/arm: avoid overflow when setting vtimer in context switch

2022-07-05 Thread Julien Grall
Hi Jiamei, On 30/06/2022 02:53, Jiamei Xie wrote: virt_vtimer_save is calculating the new time for the vtimer in: "v->arch.virt_timer.cval + v->domain->arch.virt_timer_base.offset - boot_count". In this formula, "cval + offset" might cause uint64_t overflow. Changing it to "ticks_to_ns(v->domain

Re: [PATCH v3] xen/arm: avoid overflow when setting vtimer in context switch

2022-07-05 Thread Julien Grall
: avoid overflow when setting vtimer in context switch virt_vtimer_save is calculating the new time for the vtimer in: "v->arch.virt_timer.cval + v->domain->arch.virt_timer_base.offset - boot_count". In this formula, "cval + offset" might cause uint64_t overflow. Changing

RE: [PATCH v3] xen/arm: avoid overflow when setting vtimer in context switch

2022-06-29 Thread Jiamei Xie
Hi, > -Original Message- > From: Jiamei Xie > Sent: 2022年6月30日 9:54 > To: xen-devel@lists.xenproject.org > Cc: Jiamei Xie ; Stefano Stabellini > ; Julien Grall ; Bertrand Marquis > ; Volodymyr Babchuk > ; Wei Chen > Subject: [PATCH v3] xen/arm: avoid over

[PATCH v3] xen/arm: avoid overflow when setting vtimer in context switch

2022-06-29 Thread Jiamei Xie
virt_vtimer_save is calculating the new time for the vtimer in: "v->arch.virt_timer.cval + v->domain->arch.virt_timer_base.offset - boot_count". In this formula, "cval + offset" might cause uint64_t overflow. Changing it to "ticks_to_ns(v->domain->arch.virt_timer_base.offset - boot_count) + ticks_t