Re: [PATCH v3] x86/oprofile: remove compat accessors usage from backtrace

2021-04-27 Thread Jan Beulich
On 27.04.2021 20:09, Roger Pau Monné wrote: > On Tue, Apr 27, 2021 at 05:31:25PM +0200, Jan Beulich wrote: >> On 27.04.2021 16:21, Roger Pau Monne wrote: >>> Remove the unneeded usage of the compat layer to copy frame pointers >>> from guest address space. Instead just use raw_copy_from_guest. >>>

Re: [PATCH v3] x86/oprofile: remove compat accessors usage from backtrace

2021-04-27 Thread Jan Beulich
On 27.04.2021 20:07, Roger Pau Monné wrote: > On Tue, Apr 27, 2021 at 05:37:22PM +0200, Jan Beulich wrote: >> On 27.04.2021 16:21, Roger Pau Monne wrote: >>> Remove the unneeded usage of the compat layer to copy frame pointers >>> from guest address space. Instead just use raw_copy_from_guest. >>>

Re: [PATCH v3] x86/oprofile: remove compat accessors usage from backtrace

2021-04-27 Thread Roger Pau Monné
On Tue, Apr 27, 2021 at 05:31:25PM +0200, Jan Beulich wrote: > On 27.04.2021 16:21, Roger Pau Monne wrote: > > Remove the unneeded usage of the compat layer to copy frame pointers > > from guest address space. Instead just use raw_copy_from_guest. > > > > While there change the accessibility check

Re: [PATCH v3] x86/oprofile: remove compat accessors usage from backtrace

2021-04-27 Thread Roger Pau Monné
On Tue, Apr 27, 2021 at 05:37:22PM +0200, Jan Beulich wrote: > On 27.04.2021 16:21, Roger Pau Monne wrote: > > Remove the unneeded usage of the compat layer to copy frame pointers > > from guest address space. Instead just use raw_copy_from_guest. > > > > While there change the accessibility check

Re: [PATCH v3] x86/oprofile: remove compat accessors usage from backtrace

2021-04-27 Thread Jan Beulich
On 27.04.2021 16:21, Roger Pau Monne wrote: > Remove the unneeded usage of the compat layer to copy frame pointers > from guest address space. Instead just use raw_copy_from_guest. > > While there change the accessibility check of one frame_head beyond to > be performed as part of the copy, like i

Re: [PATCH v3] x86/oprofile: remove compat accessors usage from backtrace

2021-04-27 Thread Jan Beulich
On 27.04.2021 16:21, Roger Pau Monne wrote: > Remove the unneeded usage of the compat layer to copy frame pointers > from guest address space. Instead just use raw_copy_from_guest. > > While there change the accessibility check of one frame_head beyond to > be performed as part of the copy, like i

[PATCH v3] x86/oprofile: remove compat accessors usage from backtrace

2021-04-27 Thread Roger Pau Monne
Remove the unneeded usage of the compat layer to copy frame pointers from guest address space. Instead just use raw_copy_from_guest. While there change the accessibility check of one frame_head beyond to be performed as part of the copy, like it's done in the Linux code. Note it's unclear why this