Re: [PATCH v3] x86/msi: fix locking for SR-IOV devices

2024-08-26 Thread Jan Beulich
On 25.08.2024 20:03, Stewart Hildebrand wrote: > On 8/13/24 10:01, Jan Beulich wrote: >> One aspect I didn't properly consider when making the suggestion: What if, >> without all VFs having gone away, the PF is re-added? In that case we >> would better recycle the existing structure. That's getting

Re: [PATCH v3] x86/msi: fix locking for SR-IOV devices

2024-08-25 Thread Stewart Hildebrand
On 8/13/24 10:01, Jan Beulich wrote: > On 12.08.2024 22:39, Stewart Hildebrand wrote: >> In commit 4f78438b45e2 ("vpci: use per-domain PCI lock to protect vpci >> structure") a lock moved from allocate_and_map_msi_pirq() to the caller >> and changed from pcidevs_lock() to read_lock(&d->pci_lock). H

Re: [PATCH v3] x86/msi: fix locking for SR-IOV devices

2024-08-23 Thread Stewart Hildebrand
On 8/15/24 04:36, Jan Beulich wrote: > On 15.08.2024 03:28, Stewart Hildebrand wrote: >> On 8/13/24 10:01, Jan Beulich wrote: >>> On 12.08.2024 22:39, Stewart Hildebrand wrote: @@ -446,7 +448,27 @@ static void free_pdev(struct pci_seg *pseg, struct pci_dev *pdev) list_de

Re: [PATCH v3] x86/msi: fix locking for SR-IOV devices

2024-08-15 Thread Jan Beulich
On 15.08.2024 03:28, Stewart Hildebrand wrote: > On 8/13/24 10:01, Jan Beulich wrote: >> On 12.08.2024 22:39, Stewart Hildebrand wrote: >>> In commit 4f78438b45e2 ("vpci: use per-domain PCI lock to protect vpci >>> structure") a lock moved from allocate_and_map_msi_pirq() to the caller >>> and chan

Re: [PATCH v3] x86/msi: fix locking for SR-IOV devices

2024-08-14 Thread Stewart Hildebrand
On 8/13/24 10:01, Jan Beulich wrote: > On 12.08.2024 22:39, Stewart Hildebrand wrote: >> In commit 4f78438b45e2 ("vpci: use per-domain PCI lock to protect vpci >> structure") a lock moved from allocate_and_map_msi_pirq() to the caller >> and changed from pcidevs_lock() to read_lock(&d->pci_lock). H

Re: [PATCH v3] x86/msi: fix locking for SR-IOV devices

2024-08-13 Thread Jan Beulich
On 12.08.2024 22:39, Stewart Hildebrand wrote: > In commit 4f78438b45e2 ("vpci: use per-domain PCI lock to protect vpci > structure") a lock moved from allocate_and_map_msi_pirq() to the caller > and changed from pcidevs_lock() to read_lock(&d->pci_lock). However, one > call path wasn't updated to

[PATCH v3] x86/msi: fix locking for SR-IOV devices

2024-08-12 Thread Stewart Hildebrand
In commit 4f78438b45e2 ("vpci: use per-domain PCI lock to protect vpci structure") a lock moved from allocate_and_map_msi_pirq() to the caller and changed from pcidevs_lock() to read_lock(&d->pci_lock). However, one call path wasn't updated to reflect the change, leading to a failed assertion obser