Re: [PATCH v3] mm/pdx: Add comments throughout the codebase for pdx

2023-07-17 Thread Jan Beulich
On 17.07.2023 17:17, Alejandro Vallejo wrote: > On Fri, Jul 14, 2023 at 12:36:11PM +0200, Jan Beulich wrote: >> On 14.07.2023 12:27, Alejandro Vallejo wrote: >>> On Thu, Jul 13, 2023 at 05:12:09PM +0200, Jan Beulich wrote: On 07.07.2023 18:07, Alejandro Vallejo wrote: > --- a/xen/include/x

Re: [PATCH v3] mm/pdx: Add comments throughout the codebase for pdx

2023-07-17 Thread Alejandro Vallejo
On Fri, Jul 14, 2023 at 12:36:11PM +0200, Jan Beulich wrote: > On 14.07.2023 12:27, Alejandro Vallejo wrote: > > On Thu, Jul 13, 2023 at 05:12:09PM +0200, Jan Beulich wrote: > >> On 07.07.2023 18:07, Alejandro Vallejo wrote: > >>> --- a/xen/include/xen/mm.h > >>> +++ b/xen/include/xen/mm.h > >>> @@

Re: [PATCH v3] mm/pdx: Add comments throughout the codebase for pdx

2023-07-14 Thread Jan Beulich
On 14.07.2023 12:27, Alejandro Vallejo wrote: > On Thu, Jul 13, 2023 at 05:12:09PM +0200, Jan Beulich wrote: >> On 07.07.2023 18:07, Alejandro Vallejo wrote: >>> --- a/xen/include/xen/mm.h >>> +++ b/xen/include/xen/mm.h >>> @@ -31,6 +31,17 @@ >>> * (i.e. all devices assigned to) a guest share a

Re: [PATCH v3] mm/pdx: Add comments throughout the codebase for pdx

2023-07-14 Thread Alejandro Vallejo
Hi, On Thu, Jul 13, 2023 at 05:12:09PM +0200, Jan Beulich wrote: > On 07.07.2023 18:07, Alejandro Vallejo wrote: > > --- a/xen/include/xen/mm.h > > +++ b/xen/include/xen/mm.h > > @@ -31,6 +31,17 @@ > > * (i.e. all devices assigned to) a guest share a single DMA address > > space > > * and

Re: [PATCH v3] mm/pdx: Add comments throughout the codebase for pdx

2023-07-13 Thread Jan Beulich
On 07.07.2023 18:07, Alejandro Vallejo wrote: > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -31,6 +31,17 @@ > * (i.e. all devices assigned to) a guest share a single DMA address space > * and, by default, Xen will ensure dfn == pfn. > * > + * pdx: Page InDeX > + * Indic

[PATCH v3] mm/pdx: Add comments throughout the codebase for pdx

2023-07-07 Thread Alejandro Vallejo
Document the behaviour of the pdx machinery in Xen. Some logic is fairly opaque and hard to follow without it being documented anywhere. This explains the rationale behind compression and its relationship to frametable indexing and directmap management. While modifying the file: * Convert u64 ->