Re: [PATCH v3] evtchn/fifo: don't enforce higher than necessary alignment

Hi Jan, On 22/04/2021 10:19, Jan Beulich wrote: On 21.04.2021 21:52, Julien Grall wrote: Hi, On 21/04/2021 15:36, Jan Beulich wrote: Neither the code nor the original commit provide any justification for the need to 8-byte align the struct in all cases. Enforce just as much alignment as the s

Re: [PATCH v3] evtchn/fifo: don't enforce higher than necessary alignment

On 21.04.2021 21:52, Julien Grall wrote: > Hi, > > On 21/04/2021 15:36, Jan Beulich wrote: >> Neither the code nor the original commit provide any justification for >> the need to 8-byte align the struct in all cases. Enforce just as much >> alignment as the structure actually needs - 4 bytes - by

Re: [PATCH v3] evtchn/fifo: don't enforce higher than necessary alignment

Hi, On 21/04/2021 15:36, Jan Beulich wrote: Neither the code nor the original commit provide any justification for the need to 8-byte align the struct in all cases. Enforce just as much alignment as the structure actually needs - 4 bytes - by using alignof() instead of a literal number. I had

[PATCH v3] evtchn/fifo: don't enforce higher than necessary alignment

Neither the code nor the original commit provide any justification for the need to 8-byte align the struct in all cases. Enforce just as much alignment as the structure actually needs - 4 bytes - by using alignof() instead of a literal number. While relaxation of the requirements is intended here,