Re: [PATCH v20210601 02/38] xl: fix description of migrate --debug

2021-06-02 Thread Juergen Gross
On 02.06.21 12:43, Olaf Hering wrote: Am Wed, 2 Jun 2021 08:09:00 +0200 schrieb Juergen Gross : -if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN ) +if ( ctx->save.debug ) This is no documentation change IMO. You should either mention this modification in the commit message,

Re: [PATCH v20210601 02/38] xl: fix description of migrate --debug

2021-06-02 Thread Olaf Hering
Am Wed, 2 Jun 2021 08:09:00 +0200 schrieb Juergen Gross : > > -if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN ) > > +if ( ctx->save.debug ) > This is no documentation change IMO. You should either mention this > modification in the commit message, or put it into a separate p

Re: [PATCH v20210601 02/38] xl: fix description of migrate --debug

2021-06-01 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: xl migrate --debug used to track every pfn in every batch of pages. But these times are gone. Adjust the help text to tell what --debug is supposed to do today. Signed-off-by: Olaf Hering --- docs/man/xl.1.pod.in | 4 +++- tools/libs/guest/xg_sr

[PATCH v20210601 02/38] xl: fix description of migrate --debug

2021-06-01 Thread Olaf Hering
xl migrate --debug used to track every pfn in every batch of pages. But these times are gone. Adjust the help text to tell what --debug is supposed to do today. Signed-off-by: Olaf Hering --- docs/man/xl.1.pod.in | 4 +++- tools/libs/guest/xg_sr_save.c | 2 +- tools/xl/xl_cmdtable.c