Re: [PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-26 Thread Tim Smith
On Mon, Apr 24, 2023 at 2:51 PM Paul Durrant wrote: > > So if you drop the ring drain then this patch should still stop the > SEGVs, right? > I think that's worth a few test runs. I recall some coredumps in that condition when I was investigating early on, but I don't have them in my collection s

Re: [PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-24 Thread Paul Durrant
On 24/04/2023 14:17, Tim Smith wrote: On Mon, Apr 24, 2023 at 1:08 PM Mark Syms wrote: Copying in Tim who did the final phase of the changes. On Mon, 24 Apr 2023 at 11:32, Paul Durrant wrote: On 20/04/2023 12:02, mark.s...@citrix.com wrote: From: Mark Syms Ensure the PV ring is drained

Re: [PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-24 Thread Tim Smith
On Mon, Apr 24, 2023 at 1:08 PM Mark Syms wrote: > > Copying in Tim who did the final phase of the changes. > > On Mon, 24 Apr 2023 at 11:32, Paul Durrant wrote: > > > > On 20/04/2023 12:02, mark.s...@citrix.com wrote: > > > From: Mark Syms > > > > > > Ensure the PV ring is drained on disconnect

Re: [PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-24 Thread Mark Syms
Copying in Tim who did the final phase of the changes. On Mon, 24 Apr 2023 at 11:32, Paul Durrant wrote: > > On 20/04/2023 12:02, mark.s...@citrix.com wrote: > > From: Mark Syms > > > > Ensure the PV ring is drained on disconnect. Also ensure all pending > > AIO is complete, otherwise AIO tries

Re: [PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-24 Thread Paul Durrant
On 20/04/2023 12:02, mark.s...@citrix.com wrote: From: Mark Syms Ensure the PV ring is drained on disconnect. Also ensure all pending AIO is complete, otherwise AIO tries to complete into a mapping of the ring which has been torn down. Signed-off-by: Mark Syms --- CC: Stefano Stabellini CC:

[PATCH v2 RESEND] xen: Fix SEGV on domain disconnect

2023-04-20 Thread mark.syms
From: Mark Syms Ensure the PV ring is drained on disconnect. Also ensure all pending AIO is complete, otherwise AIO tries to complete into a mapping of the ring which has been torn down. Signed-off-by: Mark Syms --- CC: Stefano Stabellini CC: Anthony Perard CC: Paul Durrant CC: xen-devel@lis