Re: [PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff

2023-01-10 Thread Alistair Francis
On Tue, Jan 10, 2023 at 5:29 PM Bobby Eshleman wrote: > > > > On Mon, Jan 9, 2023 at 4:28 PM Alistair Francis wrote: >> >> On Tue, Jan 10, 2023 at 1:47 AM Oleksii Kurochko >> wrote: >> > >> > The patch introduces a basic stuff of early_printk functionality >> > which will be enough to print 'hel

Re: [PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff

2023-01-09 Thread Bobby Eshleman
On Mon, Jan 9, 2023 at 4:28 PM Alistair Francis wrote: > On Tue, Jan 10, 2023 at 1:47 AM Oleksii Kurochko > wrote: > > > > The patch introduces a basic stuff of early_printk functionality > > which will be enough to print 'hello from C environment". > > early_printk() function was changed in com

Re: [PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff

2023-01-09 Thread Alistair Francis
On Tue, Jan 10, 2023 at 1:47 AM Oleksii Kurochko wrote: > > The patch introduces a basic stuff of early_printk functionality > which will be enough to print 'hello from C environment". > early_printk() function was changed in comparison with original as > common isn't being built now so there is n

Re: [PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff

2023-01-09 Thread Jan Beulich
On 09.01.2023 16:46, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/Kconfig.debug > +++ b/xen/arch/riscv/Kconfig.debug > @@ -0,0 +1,7 @@ > +config EARLY_PRINTK > +bool "Enable early printk config" Nit: Stray "config" in the prompt text. Jan

Re: [PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff

2023-01-09 Thread Julien Grall
Hi, On 09/01/2023 15:46, Oleksii Kurochko wrote: The patch introduces a basic stuff of early_printk functionality which will be enough to print 'hello from C environment". early_printk() function was changed in comparison with original as common isn't being built now so there is no vscnprintf.

[PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff

2023-01-09 Thread Oleksii Kurochko
The patch introduces a basic stuff of early_printk functionality which will be enough to print 'hello from C environment". early_printk() function was changed in comparison with original as common isn't being built now so there is no vscnprintf. Because printk() relies on a serial driver (like the