Re: [PATCH v2 5/5] x86: simplify is_guest_l2_slot()

2020-08-24 Thread Andrew Cooper
On 24/08/2020 13:35, Jan Beulich wrote: > is_pv_32bit_domain() has become expensive, and its use here is > redundant: Only 32-bit guests would ever get PGT_pae_xen_l2 set on > their L2 page table pages anyway. > > Suggested-by: Andrew Cooper > Signed-off-by: Jan Beulich Possibly "if some other e

Re: [PATCH v2 5/5] x86: simplify is_guest_l2_slot()

2020-08-24 Thread Jan Beulich
On 24.08.2020 14:50, Andrew Cooper wrote: > On 24/08/2020 13:35, Jan Beulich wrote: >> is_pv_32bit_domain() has become expensive, and its use here is >> redundant: Only 32-bit guests would ever get PGT_pae_xen_l2 set on >> their L2 page table pages anyway. >> >> Suggested-by: Andrew Cooper >> Sign

[PATCH v2 5/5] x86: simplify is_guest_l2_slot()

2020-08-24 Thread Jan Beulich
is_pv_32bit_domain() has become expensive, and its use here is redundant: Only 32-bit guests would ever get PGT_pae_xen_l2 set on their L2 page table pages anyway. Suggested-by: Andrew Cooper Signed-off-by: Jan Beulich --- v2: New. --- a/xen/include/asm-x86/x86_64/page.h +++ b/xen/include/asm-x