Re: [PATCH v2 5/5] x86/vPIC: check values loaded from state save record

2023-11-22 Thread Jan Beulich
On 22.11.2023 02:26, Andrew Cooper wrote: > On 16/11/2023 1:48 pm, Jan Beulich wrote: >> Loading is_master from the state save record can lead to out-of-bounds >> accesses via at least the two container_of() uses by vpic_domain() and >> __vpic_lock(). Make sure the value is consistent with the inst

Re: [PATCH v2 5/5] x86/vPIC: check values loaded from state save record

2023-11-21 Thread Andrew Cooper
On 16/11/2023 1:48 pm, Jan Beulich wrote: > Loading is_master from the state save record can lead to out-of-bounds > accesses via at least the two container_of() uses by vpic_domain() and > __vpic_lock(). Make sure the value is consistent with the instance being > loaded. > > For ->int_output (whic

[PATCH v2 5/5] x86/vPIC: check values loaded from state save record

2023-11-16 Thread Jan Beulich
Loading is_master from the state save record can lead to out-of-bounds accesses via at least the two container_of() uses by vpic_domain() and __vpic_lock(). Make sure the value is consistent with the instance being loaded. For ->int_output (which for whatever reason isn't a 1-bit bitfield), beside