On Wed, Jun 24, 2020 at 6:40 AM Andrew Cooper wrote:
>
> On 24/06/2020 11:03, Jan Beulich wrote:
> > On 23.06.2020 19:24, Andrew Cooper wrote:
> >> On 23/06/2020 09:51, Jan Beulich wrote:
> >>> On 23.06.2020 03:04, Michał Leszczyński wrote:
> - 22 cze 2020 o 18:16, Jan Beulich jbeul...@su
On 24/06/2020 11:03, Jan Beulich wrote:
> On 23.06.2020 19:24, Andrew Cooper wrote:
>> On 23/06/2020 09:51, Jan Beulich wrote:
>>> On 23.06.2020 03:04, Michał Leszczyński wrote:
- 22 cze 2020 o 18:16, Jan Beulich jbeul...@suse.com napisał(a):
> On 22.06.2020 18:02, Michał Leszczyń
- 23 cze 2020 o 19:24, Andrew Cooper andrew.coop...@citrix.com napisał(a):
> On 23/06/2020 09:51, Jan Beulich wrote:
>> I'd still like to see an explicit confirmation by him that this
>> use of memory is indeed what he has intended. There are much smaller
>> amounts of memory which we allocate
On 23.06.2020 19:24, Andrew Cooper wrote:
> On 23/06/2020 09:51, Jan Beulich wrote:
>> On 23.06.2020 03:04, Michał Leszczyński wrote:
>>> - 22 cze 2020 o 18:16, Jan Beulich jbeul...@suse.com napisał(a):
>>>
On 22.06.2020 18:02, Michał Leszczyński wrote:
> - 22 cze 2020 o 17:22, Jan
On 23/06/2020 09:51, Jan Beulich wrote:
> On 23.06.2020 03:04, Michał Leszczyński wrote:
>> - 22 cze 2020 o 18:16, Jan Beulich jbeul...@suse.com napisał(a):
>>
>>> On 22.06.2020 18:02, Michał Leszczyński wrote:
- 22 cze 2020 o 17:22, Jan Beulich jbeul...@suse.com napisał(a):
> On 2
On 23.06.2020 03:04, Michał Leszczyński wrote:
> - 22 cze 2020 o 18:16, Jan Beulich jbeul...@suse.com napisał(a):
>
>> On 22.06.2020 18:02, Michał Leszczyński wrote:
>>> - 22 cze 2020 o 17:22, Jan Beulich jbeul...@suse.com napisał(a):
On 22.06.2020 16:35, Michał Leszczyński wrote:
>>>
On 22.06.2020 19:05, Michał Leszczyński wrote:
>> +struct xen_hvm_vmtrace_op {
>> +/* IN variable */
>> +uint32_t version; /* HVMOP_VMTRACE_INTERFACE_VERSION */
>> +uint32_t cmd;
>> +/* Enable/disable external vmtrace for given domain */
>> +#define HVMOP_vmtra
- 22 cze 2020 o 18:16, Jan Beulich jbeul...@suse.com napisał(a):
> On 22.06.2020 18:02, Michał Leszczyński wrote:
>> - 22 cze 2020 o 17:22, Jan Beulich jbeul...@suse.com napisał(a):
>>> On 22.06.2020 16:35, Michał Leszczyński wrote:
- 22 cze 2020 o 15:25, Jan Beulich jbeul...@suse
> +struct xen_hvm_vmtrace_op {
> +/* IN variable */
> +uint32_t version; /* HVMOP_VMTRACE_INTERFACE_VERSION */
> +uint32_t cmd;
> +/* Enable/disable external vmtrace for given domain */
> +#define HVMOP_vmtrace_ipt_enable 1
> +#define HVMOP_vmtrace_ipt
- 22 cze 2020 o 18:25, Roger Pau Monné roger@citrix.com napisał(a):
> On Mon, Jun 22, 2020 at 06:16:57PM +0200, Jan Beulich wrote:
>> On 22.06.2020 18:02, Michał Leszczyński wrote:
>> > - 22 cze 2020 o 17:22, Jan Beulich jbeul...@suse.com napisał(a):
>> >> On 22.06.2020 16:35, Michał L
On Mon, Jun 22, 2020 at 06:16:57PM +0200, Jan Beulich wrote:
> On 22.06.2020 18:02, Michał Leszczyński wrote:
> > - 22 cze 2020 o 17:22, Jan Beulich jbeul...@suse.com napisał(a):
> >> On 22.06.2020 16:35, Michał Leszczyński wrote:
> >>> - 22 cze 2020 o 15:25, Jan Beulich jbeul...@suse.com n
- 22 cze 2020 o 18:16, Jan Beulich jbeul...@suse.com napisał(a):
> On 22.06.2020 18:02, Michał Leszczyński wrote:
>> - 22 cze 2020 o 17:22, Jan Beulich jbeul...@suse.com napisał(a):
>>> On 22.06.2020 16:35, Michał Leszczyński wrote:
- 22 cze 2020 o 15:25, Jan Beulich jbeul...@suse
On 22.06.2020 18:02, Michał Leszczyński wrote:
> - 22 cze 2020 o 17:22, Jan Beulich jbeul...@suse.com napisał(a):
>> On 22.06.2020 16:35, Michał Leszczyński wrote:
>>> - 22 cze 2020 o 15:25, Jan Beulich jbeul...@suse.com napisał(a):
Is any of what you do in this switch() actually legit
- 22 cze 2020 o 17:22, Jan Beulich jbeul...@suse.com napisał(a):
> On 22.06.2020 16:35, Michał Leszczyński wrote:
>> - 22 cze 2020 o 15:25, Jan Beulich jbeul...@suse.com napisał(a):
>>> On 19.06.2020 01:41, Michał Leszczyński wrote:
+
+domain_pause(d);
>>>
>>> Who's the inten
On 22.06.2020 16:35, Michał Leszczyński wrote:
> - 22 cze 2020 o 15:25, Jan Beulich jbeul...@suse.com napisał(a):
>> On 19.06.2020 01:41, Michał Leszczyński wrote:
>>> +
>>> +domain_pause(d);
>>
>> Who's the intended caller of this interface? You making it a hvm-op
>> suggests the guest may
- 22 cze 2020 o 15:25, Jan Beulich jbeul...@suse.com napisał(a):
> On 19.06.2020 01:41, Michał Leszczyński wrote:
>> +
>> +domain_pause(d);
>
> Who's the intended caller of this interface? You making it a hvm-op
> suggests the guest may itself call this. But of course a guest
> can't paus
On 19.06.2020 01:41, Michał Leszczyński wrote:
> @@ -1631,6 +1649,8 @@ void hvm_vcpu_destroy(struct vcpu *v)
> vlapic_destroy(v);
>
> hvm_vcpu_cacheattr_destroy(v);
> +
> +hvm_vmtrace_destroy(v);
> }
Whenever possible resource cleanup should occur from
hvm_domain_relinquish_resour
On 22.06.2020 04:56, Michał Leszczyński wrote:
> - 19 cze 2020 o 1:41, Michał Leszczyński michal.leszczyn...@cert.pl
> napisał(a):
>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> @@ -508,11 +508,25 @@ static void vmx_restore_host_msrs(void)
>>
>> static void vmx_save
- 19 cze 2020 o 1:41, Michał Leszczyński michal.leszczyn...@cert.pl
napisał(a):
> Provide an interface for privileged domains to manage
> external IPT monitoring. Guest IPT state will be preserved
> across vmentry/vmexit using ipt_state structure.
>
> Signed-off-by: Michal Leszczynski
> ---
- 19 cze 2020 o 17:50, Jan Beulich jbeul...@suse.com napisał(a):
> On 19.06.2020 17:30, Roger Pau Monné wrote:
>> On Fri, Jun 19, 2020 at 01:41:03AM +0200, Michał Leszczyński wrote:
>>> --- a/xen/arch/x86/hvm/hvm.c
>>> +++ b/xen/arch/x86/hvm/hvm.c
>>> @@ -1612,6 +1612,24 @@ int hvm_vcpu_initia
On 19.06.2020 17:30, Roger Pau Monné wrote:
> On Fri, Jun 19, 2020 at 01:41:03AM +0200, Michał Leszczyński wrote:
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -1612,6 +1612,24 @@ int hvm_vcpu_initialise(struct vcpu *v)
>> return rc;
>> }
>>
>> +void hvm_vmtrace_dest
On Fri, Jun 19, 2020 at 01:41:03AM +0200, Michał Leszczyński wrote:
> Provide an interface for privileged domains to manage
> external IPT monitoring. Guest IPT state will be preserved
> across vmentry/vmexit using ipt_state structure.
Thanks! I have some comments below, some of them are cosmetic
- 19 cze 2020 o 1:41, Michał Leszczyński michal.leszczyn...@cert.pl
napisał(a):
> Provide an interface for privileged domains to manage
> external IPT monitoring. Guest IPT state will be preserved
> across vmentry/vmexit using ipt_state structure.
>
> Signed-off-by: Michal Leszczynski
> ---
Provide an interface for privileged domains to manage
external IPT monitoring. Guest IPT state will be preserved
across vmentry/vmexit using ipt_state structure.
Signed-off-by: Michal Leszczynski
---
xen/arch/x86/hvm/hvm.c | 167 +
xen/arch/x86/hvm/vmx/vmx
24 matches
Mail list logo
