Re: [PATCH v2 4/5] x86/vPIT: check values loaded from state save record

2023-11-22 Thread Jan Beulich
On 22.11.2023 01:37, Andrew Cooper wrote: > On 16/11/2023 1:47 pm, Jan Beulich wrote: >> @@ -427,6 +428,47 @@ static int cf_check pit_save(struct vcpu >> return rc; >> } >> >> +static int cf_check pit_check(const struct domain *d, hvm_domain_context_t >> *h) >> +{ >> +const struct hvm_

Re: [PATCH v2 4/5] x86/vPIT: check values loaded from state save record

2023-11-21 Thread Andrew Cooper
On 16/11/2023 1:47 pm, Jan Beulich wrote: > In particular pit_latch_status() and speaker_ioport_read() perform > calculations which assume in-bounds values. Several of the state save > record fields can hold wider ranges, though. Refuse to load values which > cannot result from normal operation, ex

[PATCH v2 4/5] x86/vPIT: check values loaded from state save record

2023-11-16 Thread Jan Beulich
In particular pit_latch_status() and speaker_ioport_read() perform calculations which assume in-bounds values. Several of the state save record fields can hold wider ranges, though. Refuse to load values which cannot result from normal operation, except mode, the init state of which (see also below