Re: [PATCH v2 4/4] xen/pci: solve compilation error on ARM with HAS_PCI enabled.

2020-11-06 Thread Rahul Singh
Hello Jan, > On 6 Nov 2020, at 9:21 am, Jan Beulich wrote: > > On 03.11.2020 16:59, Rahul Singh wrote: >> If mem-sharing, mem-paging and log-dirty functionality is not enabled >> for architecture when HAS_PCI is enabled, compiler will throw an error. > > Nit: Is it really "and", not "or”? Ok y

Re: [PATCH v2 4/4] xen/pci: solve compilation error on ARM with HAS_PCI enabled.

2020-11-06 Thread Jan Beulich
On 03.11.2020 16:59, Rahul Singh wrote: > If mem-sharing, mem-paging and log-dirty functionality is not enabled > for architecture when HAS_PCI is enabled, compiler will throw an error. Nit: Is it really "and", not "or"? > @@ -1418,12 +1417,7 @@ static int assign_device(struct domain *d, u16 seg,

Re: [PATCH v2 4/4] xen/pci: solve compilation error on ARM with HAS_PCI enabled.

2020-11-04 Thread Bertrand Marquis
> On 3 Nov 2020, at 15:59, Rahul Singh wrote: > > If mem-sharing, mem-paging and log-dirty functionality is not enabled > for architecture when HAS_PCI is enabled, compiler will throw an error. > > Move code to x86 specific directory to fix compilation error. > > No functional change. > > S

[PATCH v2 4/4] xen/pci: solve compilation error on ARM with HAS_PCI enabled.

2020-11-03 Thread Rahul Singh
If mem-sharing, mem-paging and log-dirty functionality is not enabled for architecture when HAS_PCI is enabled, compiler will throw an error. Move code to x86 specific directory to fix compilation error. No functional change. Signed-off-by: Rahul Singh --- Changes in v2: - Move mem-sharing ,