Re: [PATCH v2 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-11-06 Thread Rahul Singh
Hello Jan, > On 6 Nov 2020, at 9:09 am, Jan Beulich wrote: > > On 03.11.2020 16:59, Rahul Singh wrote: >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -14,7 +14,6 @@ >> * this program; If not, see . >> */ >> >> -#include Remo

Re: [PATCH v2 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-11-06 Thread Jan Beulich
On 03.11.2020 16:59, Rahul Singh wrote: > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -14,7 +14,6 @@ > * this program; If not, see . > */ > > -#include > #include > #include > #include I think this hunk wants dropping -

Re: [PATCH v2 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-11-05 Thread Stefano Stabellini
On Tue, 3 Nov 2020, Rahul Singh wrote: > passthrough/pci.c file is common for all architecture, but there is x86 > sepcific code in this file. ^ specific Aside from that: Reviewed-by: Stefano Stabellini > Move x86 specific code to the x86 directory to avoid compilation error > for other arc

Re: [PATCH v2 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-11-04 Thread Bertrand Marquis
> On 3 Nov 2020, at 15:59, Rahul Singh wrote: > > passthrough/pci.c file is common for all architecture, but there is x86 > sepcific code in this file. > > Move x86 specific code to the x86 directory to avoid compilation error > for other architecture. > > No functional change. > > Signed-o

[PATCH v2 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-11-03 Thread Rahul Singh
passthrough/pci.c file is common for all architecture, but there is x86 sepcific code in this file. Move x86 specific code to the x86 directory to avoid compilation error for other architecture. No functional change. Signed-off-by: Rahul Singh --- Changes is v2: - fixed comments. - rename pc