Re: [PATCH v2 3/3] x86: Add support for CpuidUserDis

2023-05-11 Thread Jan Beulich
On 11.05.2023 14:12, Alejandro Vallejo wrote: > On Thu, May 11, 2023 at 01:05:42PM +0200, Jan Beulich wrote: >>> --- a/xen/arch/x86/cpu/amd.c >>> +++ b/xen/arch/x86/cpu/amd.c >>> @@ -279,8 +279,12 @@ static void __init noinline amd_init_levelling(void) >>> * that can only be present when Xen i

Re: [PATCH v2 3/3] x86: Add support for CpuidUserDis

2023-05-11 Thread Alejandro Vallejo
On Thu, May 11, 2023 at 01:05:42PM +0200, Jan Beulich wrote: > > --- a/xen/arch/x86/cpu/amd.c > > +++ b/xen/arch/x86/cpu/amd.c > > @@ -279,8 +279,12 @@ static void __init noinline amd_init_levelling(void) > > * that can only be present when Xen is itself virtualized (because > > * it can

Re: [PATCH v2 3/3] x86: Add support for CpuidUserDis

2023-05-11 Thread Jan Beulich
On 09.05.2023 18:43, Alejandro Vallejo wrote: > Because CpuIdUserDis is reported in CPUID itself, the extended leaf > containing that bit must be retrieved before calling c_early_init() > > Signed-off-by: Alejandro Vallejo Looks largely okay when taken together with patch 2, but ... > --- a/xen

[PATCH v2 3/3] x86: Add support for CpuidUserDis

2023-05-09 Thread Alejandro Vallejo
Because CpuIdUserDis is reported in CPUID itself, the extended leaf containing that bit must be retrieved before calling c_early_init() Signed-off-by: Alejandro Vallejo --- v2: * Style fixes * MSR index inlined in rdmsr/wrmsr * Swapped Intel's conditional guard so typically true condition goes