Re: [PATCH v2 3/3] pci/msi: remove pci_msi_ignore_mask

2025-02-06 Thread Bjorn Helgaas
On Thu, Feb 06, 2025 at 09:33:26AM +0100, Roger Pau Monné wrote: > On Wed, Feb 05, 2025 at 09:17:31AM -0600, Bjorn Helgaas wrote: > > Please run git log --oneline and match the subject line capitalization > > style, i.e., > > > > PCI/MSI: Remove ... > > > > But it doesn't look like this actuall

Re: [PATCH v2 3/3] pci/msi: remove pci_msi_ignore_mask

2025-02-06 Thread Roger Pau Monné
On Wed, Feb 05, 2025 at 09:17:31AM -0600, Bjorn Helgaas wrote: > Please run git log --oneline and match the subject line capitalization > style, i.e., > > PCI/MSI: Remove ... > > But it doesn't look like this actually *removes* the functionality, it > just implements it differently so it can be

Re: [PATCH v2 3/3] pci/msi: remove pci_msi_ignore_mask

2025-02-05 Thread Bjorn Helgaas
Please run git log --oneline and match the subject line capitalization style, i.e., PCI/MSI: Remove ... But it doesn't look like this actually *removes* the functionality, it just implements it differently so it can be applied more selectively. So maybe the subject should say something like "c

[PATCH v2 3/3] pci/msi: remove pci_msi_ignore_mask

2025-01-14 Thread Roger Pau Monne
Setting pci_msi_ignore_mask inhibits the toggling of the mask bit for both MSI and MSI-X entries globally, regardless of the IRQ chip they are using. Only Xen sets the pci_msi_ignore_mask when routing physical interrupts over event channels, to prevent PCI code from attempting to toggle the maskbit