Re: [PATCH v2 2/5] x86/vga: fix mapping of the VGA text buffer

2025-03-18 Thread Jan Beulich
On 18.03.2025 14:11, Andrew Cooper wrote: > On 18/03/2025 9:19 am, Roger Pau Monne wrote: >> The call to ioremap_wc() in video_init() will always fail, because >> video_init() is called ahead of vm_init_type(), and so the underlying >> __vmap() call will fail to allocate the linear address space. >

Re: [PATCH v2 2/5] x86/vga: fix mapping of the VGA text buffer

2025-03-18 Thread Jan Beulich
On 18.03.2025 16:31, Roger Pau Monné wrote: > On Tue, Mar 18, 2025 at 03:28:32PM +0100, Jan Beulich wrote: >> On 18.03.2025 14:11, Andrew Cooper wrote: >>> On 18/03/2025 9:19 am, Roger Pau Monne wrote: The call to ioremap_wc() in video_init() will always fail, because video_init() is call

Re: [PATCH v2 2/5] x86/vga: fix mapping of the VGA text buffer

2025-03-18 Thread Roger Pau Monné
On Tue, Mar 18, 2025 at 03:28:32PM +0100, Jan Beulich wrote: > On 18.03.2025 14:11, Andrew Cooper wrote: > > On 18/03/2025 9:19 am, Roger Pau Monne wrote: > >> The call to ioremap_wc() in video_init() will always fail, because > >> video_init() is called ahead of vm_init_type(), and so the underlyi

Re: [PATCH v2 2/5] x86/vga: fix mapping of the VGA text buffer

2025-03-18 Thread Andrew Cooper
On 18/03/2025 9:19 am, Roger Pau Monne wrote: > The call to ioremap_wc() in video_init() will always fail, because > video_init() is called ahead of vm_init_type(), and so the underlying > __vmap() call will fail to allocate the linear address space. > > Fix by reverting to the previous behavior an

[PATCH v2 2/5] x86/vga: fix mapping of the VGA text buffer

2025-03-18 Thread Roger Pau Monne
The call to ioremap_wc() in video_init() will always fail, because video_init() is called ahead of vm_init_type(), and so the underlying __vmap() call will fail to allocate the linear address space. Fix by reverting to the previous behavior and using ioremap() for the VGA text buffer. Fixes: 81d1