Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-23 Thread Boris Ostrovsky
On 2/23/21 1:02 PM, Roger Pau Monné wrote: > On Tue, Feb 23, 2021 at 11:40:07AM -0500, Boris Ostrovsky wrote: >> On 2/23/21 11:11 AM, Roger Pau Monné wrote: >>> On Tue, Feb 23, 2021 at 10:39:48AM -0500, Boris Ostrovsky wrote: >>> Before I do that though --- what was the conclusion on verbosi

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-23 Thread Roger Pau Monné
On Tue, Feb 23, 2021 at 11:40:07AM -0500, Boris Ostrovsky wrote: > > On 2/23/21 11:11 AM, Roger Pau Monné wrote: > > On Tue, Feb 23, 2021 at 10:39:48AM -0500, Boris Ostrovsky wrote: > > > >> Before I do that though --- what was the conclusion on verbosity control? > > Ideally I would like to find

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-23 Thread Roger Pau Monné
On Tue, Feb 23, 2021 at 05:10:16PM +0100, Jan Beulich wrote: > On 23.02.2021 16:39, Boris Ostrovsky wrote: > > Before I do that though --- what was the conclusion on verbosity > > control? > > Not sure - afaict the conclusion was that we still don't really > agree. Roger? As I said on my reply to

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-23 Thread Boris Ostrovsky
On 2/23/21 11:11 AM, Roger Pau Monné wrote: > On Tue, Feb 23, 2021 at 10:39:48AM -0500, Boris Ostrovsky wrote: > >> Before I do that though --- what was the conclusion on verbosity control? > Ideally I would like to find a way to have a more generic interface to > change verbosity level on a per-

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-23 Thread Roger Pau Monné
On Tue, Feb 23, 2021 at 10:39:48AM -0500, Boris Ostrovsky wrote: > > On 2/23/21 8:23 AM, Jan Beulich wrote: > > On 23.02.2021 13:17, Roger Pau Monné wrote: > >> On Tue, Feb 23, 2021 at 11:15:31AM +0100, Jan Beulich wrote: > >>> On 23.02.2021 10:34, Roger Pau Monné wrote: > On Tue, Feb 23, 202

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-23 Thread Jan Beulich
On 23.02.2021 16:39, Boris Ostrovsky wrote: > > On 2/23/21 8:23 AM, Jan Beulich wrote: >> On 23.02.2021 13:17, Roger Pau Monné wrote: >>> On Tue, Feb 23, 2021 at 11:15:31AM +0100, Jan Beulich wrote: On 23.02.2021 10:34, Roger Pau Monné wrote: > On Tue, Feb 23, 2021 at 08:57:00AM +0100, Ja

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-23 Thread Boris Ostrovsky
On 2/23/21 8:23 AM, Jan Beulich wrote: > On 23.02.2021 13:17, Roger Pau Monné wrote: >> On Tue, Feb 23, 2021 at 11:15:31AM +0100, Jan Beulich wrote: >>> On 23.02.2021 10:34, Roger Pau Monné wrote: On Tue, Feb 23, 2021 at 08:57:00AM +0100, Jan Beulich wrote: > On 22.02.2021 22:19, Boris O

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-23 Thread Jan Beulich
On 23.02.2021 13:17, Roger Pau Monné wrote: > On Tue, Feb 23, 2021 at 11:15:31AM +0100, Jan Beulich wrote: >> On 23.02.2021 10:34, Roger Pau Monné wrote: >>> On Tue, Feb 23, 2021 at 08:57:00AM +0100, Jan Beulich wrote: On 22.02.2021 22:19, Boris Ostrovsky wrote: > > On 2/22/21 6:08 AM,

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-23 Thread Roger Pau Monné
On Tue, Feb 23, 2021 at 11:15:31AM +0100, Jan Beulich wrote: > On 23.02.2021 10:34, Roger Pau Monné wrote: > > On Tue, Feb 23, 2021 at 08:57:00AM +0100, Jan Beulich wrote: > >> On 22.02.2021 22:19, Boris Ostrovsky wrote: > >>> > >>> On 2/22/21 6:08 AM, Roger Pau Monné wrote: > On Fri, Feb 19,

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-23 Thread Jan Beulich
On 23.02.2021 10:34, Roger Pau Monné wrote: > On Tue, Feb 23, 2021 at 08:57:00AM +0100, Jan Beulich wrote: >> On 22.02.2021 22:19, Boris Ostrovsky wrote: >>> >>> On 2/22/21 6:08 AM, Roger Pau Monné wrote: On Fri, Feb 19, 2021 at 09:56:32AM -0500, Boris Ostrovsky wrote: > On 2/18/21 5:51 AM

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-23 Thread Roger Pau Monné
On Tue, Feb 23, 2021 at 08:57:00AM +0100, Jan Beulich wrote: > On 22.02.2021 22:19, Boris Ostrovsky wrote: > > > > On 2/22/21 6:08 AM, Roger Pau Monné wrote: > >> On Fri, Feb 19, 2021 at 09:56:32AM -0500, Boris Ostrovsky wrote: > >>> On 2/18/21 5:51 AM, Roger Pau Monné wrote: > On Wed, Jan 20

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-22 Thread Jan Beulich
On 22.02.2021 22:19, Boris Ostrovsky wrote: > > On 2/22/21 6:08 AM, Roger Pau Monné wrote: >> On Fri, Feb 19, 2021 at 09:56:32AM -0500, Boris Ostrovsky wrote: >>> On 2/18/21 5:51 AM, Roger Pau Monné wrote: On Wed, Jan 20, 2021 at 05:49:10PM -0500, Boris Ostrovsky wrote: > When toolstack u

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-22 Thread Boris Ostrovsky
On 2/22/21 6:08 AM, Roger Pau Monné wrote: > On Fri, Feb 19, 2021 at 09:56:32AM -0500, Boris Ostrovsky wrote: >> On 2/18/21 5:51 AM, Roger Pau Monné wrote: >>> On Wed, Jan 20, 2021 at 05:49:10PM -0500, Boris Ostrovsky wrote: When toolstack updates MSR policy, this MSR offset (which is the la

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-22 Thread Roger Pau Monné
On Fri, Feb 19, 2021 at 09:56:32AM -0500, Boris Ostrovsky wrote: > > On 2/18/21 5:51 AM, Roger Pau Monné wrote: > > On Wed, Jan 20, 2021 at 05:49:10PM -0500, Boris Ostrovsky wrote: > >> When toolstack updates MSR policy, this MSR offset (which is the last > >> index in the hypervisor MSR range) is

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-19 Thread Boris Ostrovsky
On 2/18/21 5:51 AM, Roger Pau Monné wrote: > On Wed, Jan 20, 2021 at 05:49:10PM -0500, Boris Ostrovsky wrote: >> When toolstack updates MSR policy, this MSR offset (which is the last >> index in the hypervisor MSR range) is used to indicate hypervisor >> behavior when guest accesses an MSR which

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-18 Thread Roger Pau Monné
On Wed, Jan 20, 2021 at 05:49:10PM -0500, Boris Ostrovsky wrote: > When toolstack updates MSR policy, this MSR offset (which is the last > index in the hypervisor MSR range) is used to indicate hypervisor > behavior when guest accesses an MSR which is not explicitly emulated. It's kind of weird to

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-02-02 Thread Boris Ostrovsky
On 1/22/21 6:51 AM, Jan Beulich wrote: > Also, Andrew, (I think I did say so before) - I definitely > would want your general consent with this model, as what gets > altered here is almost all relatively recent contributions > by you. Nor would I exclude the approach being controversial. > Andre

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-01-22 Thread Boris Ostrovsky
On 1/22/21 6:51 AM, Jan Beulich wrote: > On 20.01.2021 23:49, Boris Ostrovsky wrote: >> --- a/xen/arch/x86/msr.c >> +++ b/xen/arch/x86/msr.c >> @@ -295,7 +295,7 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t >> *val) >> } >> >> /* Fallthrough. */ >> -case 0x40

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-01-22 Thread Jan Beulich
On 20.01.2021 23:49, Boris Ostrovsky wrote: > --- a/xen/arch/x86/msr.c > +++ b/xen/arch/x86/msr.c > @@ -295,7 +295,7 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t > *val) > } > > /* Fallthrough. */ > -case 0x4200 ... 0x42ff: > +case 0x4200 ... 0x

[PATCH v2 2/4] x86: Introduce MSR_UNHANDLED

2021-01-20 Thread Boris Ostrovsky
When toolstack updates MSR policy, this MSR offset (which is the last index in the hypervisor MSR range) is used to indicate hypervisor behavior when guest accesses an MSR which is not explicitly emulated. Signed-off-by: Boris Ostrovsky --- Changes in v2: * Use 0x42ff for MSR_UNHANDLED * Pass