Re: [PATCH v2 2/2] xen: do not use '%ms' scanf specifier

2025-01-15 Thread David Woodhouse
On Wed, 2025-01-15 at 15:36 +0100, Anthony PERARD wrote: > On Fri, Jan 10, 2025 at 10:35:31AM +0100, Roger Pau Monne wrote: > > diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c > > index ef0c2912efa1..989e75fef88f 100644 > > --- a/hw/char/xen_console.c > > +++ b/hw/char/xen_console.c > >

Re: [PATCH v2 2/2] xen: do not use '%ms' scanf specifier

2025-01-15 Thread Anthony PERARD
On Fri, Jan 10, 2025 at 10:35:31AM +0100, Roger Pau Monne wrote: > diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c > index ef0c2912efa1..989e75fef88f 100644 > --- a/hw/char/xen_console.c > +++ b/hw/char/xen_console.c > @@ -550,7 +550,8 @@ static void xen_console_device_create(XenBackendI

Re: [PATCH v2 2/2] xen: do not use '%ms' scanf specifier

2025-01-10 Thread David Woodhouse
On Fri, 2025-01-10 at 10:35 +0100, Roger Pau Monne wrote: > The 'm' parameter used to request auto-allocation of the destination variable > is not supported on FreeBSD, and as such leads to failures to parse. > > What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as > it ju

[PATCH v2 2/2] xen: do not use '%ms' scanf specifier

2025-01-10 Thread Roger Pau Monne
The 'm' parameter used to request auto-allocation of the destination variable is not supported on FreeBSD, and as such leads to failures to parse. What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as it just leads to a double allocation of the same string. Instead use xs_