Re: [PATCH v2 2/2] xen/domain: rewrite emulation_flags_ok()

2025-05-21 Thread dmkhn
On Wed, May 21, 2025 at 05:07:12PM +0200, Roger Pau Monné wrote: > On Fri, May 16, 2025 at 02:29:16AM +, dm...@proton.me wrote: > > From: Denis Mukhin > > > > Rewrite emulation_flags_ok() to simplify future modifications. > > > > Also, introduce X86_EMU_{BASELINE,OPTIONAL} helper macros. > > >

Re: [PATCH v2 2/2] xen/domain: rewrite emulation_flags_ok()

2025-05-21 Thread Roger Pau Monné
On Fri, May 16, 2025 at 02:29:16AM +, dm...@proton.me wrote: > From: Denis Mukhin > > Rewrite emulation_flags_ok() to simplify future modifications. > > Also, introduce X86_EMU_{BASELINE,OPTIONAL} helper macros. > > No functional change intended. > > Signed-off-by: Denis Mukhin > --- > Ch

Re: [PATCH v2 2/2] xen/domain: rewrite emulation_flags_ok()

2025-05-20 Thread Jan Beulich
On 21.05.2025 01:00, Stefano Stabellini wrote: > On Tue, 20 May 2025, dm...@proton.me wrote: >> On Tue, May 20, 2025 at 05:24:33PM +0200, Jan Beulich wrote: >>> On 16.05.2025 04:29, dm...@proton.me wrote: --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h

Re: [PATCH v2 2/2] xen/domain: rewrite emulation_flags_ok()

2025-05-20 Thread Jan Beulich
On 21.05.2025 00:38, dm...@proton.me wrote: > On Tue, May 20, 2025 at 05:24:33PM +0200, Jan Beulich wrote: >> On 16.05.2025 04:29, dm...@proton.me wrote: >>> --- a/xen/arch/x86/include/asm/domain.h >>> +++ b/xen/arch/x86/include/asm/domain.h >>> @@ -494,6 +494,12 @@ struct arch_domain >>>

Re: [PATCH v2 2/2] xen/domain: rewrite emulation_flags_ok()

2025-05-20 Thread Stefano Stabellini
On Tue, 20 May 2025, dm...@proton.me wrote: > On Tue, May 20, 2025 at 05:24:33PM +0200, Jan Beulich wrote: > > On 16.05.2025 04:29, dm...@proton.me wrote: > > > --- a/xen/arch/x86/include/asm/domain.h > > > +++ b/xen/arch/x86/include/asm/domain.h > > > @@ -494,6 +494,12 @@ struct arch_domain > > >

Re: [PATCH v2 2/2] xen/domain: rewrite emulation_flags_ok()

2025-05-20 Thread dmkhn
On Tue, May 20, 2025 at 05:24:33PM +0200, Jan Beulich wrote: > On 16.05.2025 04:29, dm...@proton.me wrote: > > --- a/xen/arch/x86/include/asm/domain.h > > +++ b/xen/arch/x86/include/asm/domain.h > > @@ -494,6 +494,12 @@ struct arch_domain > > X86_EMU_PIT | X86_EMU_

Re: [PATCH v2 2/2] xen/domain: rewrite emulation_flags_ok()

2025-05-20 Thread Jan Beulich
On 16.05.2025 04:29, dm...@proton.me wrote: > --- a/xen/arch/x86/include/asm/domain.h > +++ b/xen/arch/x86/include/asm/domain.h > @@ -494,6 +494,12 @@ struct arch_domain > X86_EMU_PIT | X86_EMU_USE_PIRQ | \ > X86_EMU_VPCI) >

[PATCH v2 2/2] xen/domain: rewrite emulation_flags_ok()

2025-05-15 Thread dmkhn
From: Denis Mukhin Rewrite emulation_flags_ok() to simplify future modifications. Also, introduce X86_EMU_{BASELINE,OPTIONAL} helper macros. No functional change intended. Signed-off-by: Denis Mukhin --- Changes since v1: - kept use of non-public X86_EMU_XXX flags - corrected some comments an