Re: [PATCH v2 2/2] xen/arm: vpl011: Fix domain_vpl011_init error path

2023-03-29 Thread Julien Grall
Hi, On 24/03/2023 09:35, Luca Fancellu wrote: On 23 Mar 2023, at 13:56, Michal Orzel wrote: When vgic_reserve_virq() fails and backend is in domain, we should also free the allocated event channel. When backend is in Xen and call to xzalloc() returns NULL, there is no need to call xfree().

Re: [PATCH v2 2/2] xen/arm: vpl011: Fix domain_vpl011_init error path

2023-03-24 Thread Luca Fancellu
> On 23 Mar 2023, at 13:56, Michal Orzel wrote: > > When vgic_reserve_virq() fails and backend is in domain, we should also > free the allocated event channel. > > When backend is in Xen and call to xzalloc() returns NULL, there is no > need to call xfree(). This should be done instead on an

[PATCH v2 2/2] xen/arm: vpl011: Fix domain_vpl011_init error path

2023-03-23 Thread Michal Orzel
When vgic_reserve_virq() fails and backend is in domain, we should also free the allocated event channel. When backend is in Xen and call to xzalloc() returns NULL, there is no need to call xfree(). This should be done instead on an error path from vgic_reserve_virq(). Moreover, we should be calli