Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-02-03 Thread Oleksii
On Fri, 2023-02-03 at 13:23 +, Julien Grall wrote: > > > On 03/02/2023 13:15, Oleksii wrote: > > Hi Julien, > > Hi Oleksii, > > > On Wed, 2023-02-01 at 22:11 +, Julien Grall wrote: > > I am trying to introduce GENERIC_BUG_FRAME config ( only for ARM > > now as > > some stuff isn't avail

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-02-03 Thread Julien Grall
On 03/02/2023 13:15, Oleksii wrote: Hi Julien, Hi Oleksii, On Wed, 2023-02-01 at 22:11 +, Julien Grall wrote: I am trying to introduce GENERIC_BUG_FRAME config ( only for ARM now as some stuff isn't available now for RISC-V such as find_text_region(), printk() and so on... Thereby I wi

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-02-03 Thread Oleksii
Hi Julien, On Wed, 2023-02-01 at 22:11 +, Julien Grall wrote: > > > On 01/02/2023 17:40, Oleksii wrote: > > Hi Julien, > > Hi Oleksii, > > > On Mon, 2023-01-30 at 22:28 +, Julien Grall wrote: > > > Hi Oleksii, > > > > > > On 30/01/2023 11:35, Oleksii wrote: > > > > Hi Julien, > > > >

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-02-02 Thread Jan Beulich
On 01.02.2023 23:11, Julien Grall wrote: > On 01/02/2023 17:40, Oleksii wrote: >> I wrote the following macros and they have been compiled without any >> errors: >> . >> #define _ASM_BUGFRAME_TEXT(second_frame) \ >>     ".Lbug%=: ebreak\n"

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-02-01 Thread Julien Grall
On 01/02/2023 17:40, Oleksii wrote: Hi Julien, Hi Oleksii, On Mon, 2023-01-30 at 22:28 +, Julien Grall wrote: Hi Oleksii, On 30/01/2023 11:35, Oleksii wrote: Hi Julien, On Fri, 2023-01-27 at 16:02 +, Julien Grall wrote: Hi Oleksii, On 27/01/2023 13:59, Oleksii Kurochko wrote:

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-02-01 Thread Oleksii
Hi Julien, On Mon, 2023-01-30 at 22:28 +, Julien Grall wrote: > Hi Oleksii, > > On 30/01/2023 11:35, Oleksii wrote: > > Hi Julien, > > On Fri, 2023-01-27 at 16:02 +, Julien Grall wrote: > > > Hi Oleksii, > > > > > > On 27/01/2023 13:59, Oleksii Kurochko wrote: > > > > The patch introduce

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-31 Thread Oleksii
On Mon, 2023-01-30 at 22:28 +, Julien Grall wrote: > Hi Oleksii, > > On 30/01/2023 11:35, Oleksii wrote: > > Hi Julien, > > On Fri, 2023-01-27 at 16:02 +, Julien Grall wrote: > > > Hi Oleksii, > > > > > > On 27/01/2023 13:59, Oleksii Kurochko wrote: > > > > The patch introduces macros: BU

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-30 Thread Julien Grall
Hi Oleksii, On 30/01/2023 11:35, Oleksii wrote: Hi Julien, On Fri, 2023-01-27 at 16:02 +, Julien Grall wrote: Hi Oleksii, On 27/01/2023 13:59, Oleksii Kurochko wrote: The patch introduces macros: BUG(), WARN(), run_in_exception(), assert_failed. The implementation uses "ebreak" instructi

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-30 Thread Juergen Gross
On 30.01.23 12:35, Oleksii wrote: Hi Julien, On Fri, 2023-01-27 at 16:02 +, Julien Grall wrote: Hi Oleksii, On 27/01/2023 13:59, Oleksii Kurochko wrote: The patch introduces macros: BUG(), WARN(), run_in_exception(), assert_failed. The implementation uses "ebreak" instruction in combinati

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-30 Thread Oleksii
Hi Julien, On Fri, 2023-01-27 at 16:02 +, Julien Grall wrote: > Hi Oleksii, > > On 27/01/2023 13:59, Oleksii Kurochko wrote: > > The patch introduces macros: BUG(), WARN(), run_in_exception(), > > assert_failed. > > > > The implementation uses "ebreak" instruction in combination with > > diff

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-30 Thread Oleksii
On Fri, 2023-01-27 at 15:34 +0100, Jan Beulich wrote: > On 27.01.2023 14:59, Oleksii Kurochko wrote: > > The patch introduces macros: BUG(), WARN(), run_in_exception(), > > assert_failed. > > > > The implementation uses "ebreak" instruction in combination with > > diffrent bug frame tables (for ea

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-27 Thread Julien Grall
Hi Oleksii, On 27/01/2023 13:59, Oleksii Kurochko wrote: The patch introduces macros: BUG(), WARN(), run_in_exception(), assert_failed. The implementation uses "ebreak" instruction in combination with diffrent bug frame tables (for each type) which contains useful information. Signed-off-by: O

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-27 Thread Jan Beulich
On 27.01.2023 14:59, Oleksii Kurochko wrote: > +int is_valid_bugaddr(uint32_t insn) > +{ > +if ((insn & INSN_LENGTH_MASK) == INSN_LENGTH_32) > +return (insn == BUG_INSN_32); > +else > +return ((insn & COMPRESSED_INSN_MASK) == BUG_INSN_16); > +} > + > void do_trap(struct cpu

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-27 Thread Jan Beulich
On 27.01.2023 14:59, Oleksii Kurochko wrote: > The patch introduces macros: BUG(), WARN(), run_in_exception(), > assert_failed. > > The implementation uses "ebreak" instruction in combination with > diffrent bug frame tables (for each type) which contains useful > information. > > Signed-off-by:

[PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-27 Thread Oleksii Kurochko
The patch introduces macros: BUG(), WARN(), run_in_exception(), assert_failed. The implementation uses "ebreak" instruction in combination with diffrent bug frame tables (for each type) which contains useful information. Signed-off-by: Oleksii Kurochko --- Changes: - Remove __ in define naming