Re: [PATCH v2 11/17] xen/arm: PCI host bridge discovery within XEN on ARM

2021-09-27 Thread Julien Grall
On Fri, 24 Sep 2021, 23:42 Stefano Stabellini, wrote: > On Fri, 24 Sep 2021, Rahul Singh wrote: > > Hi Stefano, > > > > > On 23 Sep 2021, at 8:12 pm, Stefano Stabellini > wrote: > > > > > > On Thu, 23 Sep 2021, Rahul Singh wrote: > > +goto err_exit; > > +} > > >>> > > >

Re: [PATCH v2 11/17] xen/arm: PCI host bridge discovery within XEN on ARM

2021-09-27 Thread Rahul Singh
Hi Stefano, > On 25 Sep 2021, at 12:26 am, Stefano Stabellini > wrote: > > On Fri, 24 Sep 2021, Stefano Stabellini wrote: >> On Fri, 24 Sep 2021, Rahul Singh wrote: >>> Hi Stefano, >>> On 23 Sep 2021, at 8:12 pm, Stefano Stabellini wrote: On Thu, 23 Sep 2021, Rahul Singh

Re: [PATCH v2 11/17] xen/arm: PCI host bridge discovery within XEN on ARM

2021-09-24 Thread Stefano Stabellini
On Fri, 24 Sep 2021, Stefano Stabellini wrote: > On Fri, 24 Sep 2021, Rahul Singh wrote: > > Hi Stefano, > > > > > On 23 Sep 2021, at 8:12 pm, Stefano Stabellini > > > wrote: > > > > > > On Thu, 23 Sep 2021, Rahul Singh wrote: > > +goto err_exit; > > +} > > >>> > > >>

Re: [PATCH v2 11/17] xen/arm: PCI host bridge discovery within XEN on ARM

2021-09-24 Thread Stefano Stabellini
On Fri, 24 Sep 2021, Rahul Singh wrote: > Hi Stefano, > > > On 23 Sep 2021, at 8:12 pm, Stefano Stabellini > > wrote: > > > > On Thu, 23 Sep 2021, Rahul Singh wrote: > +goto err_exit; > +} > >>> > >>> This is unnecessary at the moment, right? Can we get rid of ops->in

Re: [PATCH v2 11/17] xen/arm: PCI host bridge discovery within XEN on ARM

2021-09-24 Thread Rahul Singh
Hi Stefano, > On 23 Sep 2021, at 8:12 pm, Stefano Stabellini wrote: > > On Thu, 23 Sep 2021, Rahul Singh wrote: +goto err_exit; +} >>> >>> This is unnecessary at the moment, right? Can we get rid of ops->init ? >> >> No this is required for N1SDP board. Please check b

Re: [PATCH v2 11/17] xen/arm: PCI host bridge discovery within XEN on ARM

2021-09-23 Thread Stefano Stabellini
On Thu, 23 Sep 2021, Rahul Singh wrote: > >> +goto err_exit; > >> +} > > > > This is unnecessary at the moment, right? Can we get rid of ops->init ? > > No this is required for N1SDP board. Please check below patch. > https://gitlab.com/rahsingh/xen-integration/-/commit/6379ba5764

Re: [PATCH v2 11/17] xen/arm: PCI host bridge discovery within XEN on ARM

2021-09-23 Thread Rahul Singh
Hi Stefano, > On 23 Sep 2021, at 3:09 am, Stefano Stabellini wrote: > > On Wed, 22 Sep 2021, Rahul Singh wrote: >> XEN during boot will read the PCI device tree node “reg” property >> and will map the PCI config space to the XEN memory. >> >> As of now only "pci-host-ecam-generic" compatible bo

Re: [PATCH v2 11/17] xen/arm: PCI host bridge discovery within XEN on ARM

2021-09-23 Thread Stefano Stabellini
On Thu, 23 Sep 2021, Oleksandr Andrushchenko wrote: > Hi, Stefano! > > [snip] > > > >> +}; > >> + > >> +/* Default ECAM ops */ > >> +extern const struct pci_ecam_ops pci_generic_ecam_ops; > > If we use container_of and get rid of sysdata, I wonder if we get avoid > > exporting pci_generic_ecam_o

Re: [PATCH v2 11/17] xen/arm: PCI host bridge discovery within XEN on ARM

2021-09-23 Thread Oleksandr Andrushchenko
Hi, Stefano! [snip] >> +}; >> + >> +/* Default ECAM ops */ >> +extern const struct pci_ecam_ops pci_generic_ecam_ops; > If we use container_of and get rid of sysdata, I wonder if we get avoid > exporting pci_generic_ecam_ops. > > >> +int pci_host_common_probe(struct dt_device_node *dev, const vo

Re: [PATCH v2 11/17] xen/arm: PCI host bridge discovery within XEN on ARM

2021-09-22 Thread Stefano Stabellini
On Wed, 22 Sep 2021, Rahul Singh wrote: > XEN during boot will read the PCI device tree node “reg” property > and will map the PCI config space to the XEN memory. > > As of now only "pci-host-ecam-generic" compatible board is supported. > > "linux,pci-domain" device tree property assigns a fixed

[PATCH v2 11/17] xen/arm: PCI host bridge discovery within XEN on ARM

2021-09-22 Thread Rahul Singh
XEN during boot will read the PCI device tree node “reg” property and will map the PCI config space to the XEN memory. As of now only "pci-host-ecam-generic" compatible board is supported. "linux,pci-domain" device tree property assigns a fixed PCI domain number to a host bridge, otherwise an uns