Re: [PATCH v2 06/13] xen/bitops: Implement ffs() in common logic

2024-06-01 Thread Nicola Vetrini
On 2024-05-31 10:48, Andrew Cooper wrote: On 31/05/2024 9:34 am, Andrew Cooper wrote: On 31/05/2024 7:56 am, Nicola Vetrini wrote: On 2024-05-31 03:14, Stefano Stabellini wrote: On Fri, 24 May 2024, Andrew Cooper wrote: Perform constant-folding unconditionally, rather than having it implement

Re: [PATCH v2 06/13] xen/bitops: Implement ffs() in common logic

2024-05-31 Thread Andrew Cooper
On 31/05/2024 9:34 am, Andrew Cooper wrote: > On 31/05/2024 7:56 am, Nicola Vetrini wrote: >> On 2024-05-31 03:14, Stefano Stabellini wrote: >>> On Fri, 24 May 2024, Andrew Cooper wrote: Perform constant-folding unconditionally, rather than having it implemented inconsistency between

Re: [PATCH v2 06/13] xen/bitops: Implement ffs() in common logic

2024-05-31 Thread Andrew Cooper
On 31/05/2024 7:56 am, Nicola Vetrini wrote: > On 2024-05-31 03:14, Stefano Stabellini wrote: >> On Fri, 24 May 2024, Andrew Cooper wrote: >>> Perform constant-folding unconditionally, rather than having it >>> implemented >>> inconsistency between architectures. >>> >>> Confirm the expected behavi

Re: [PATCH v2 06/13] xen/bitops: Implement ffs() in common logic

2024-05-30 Thread Nicola Vetrini
On 2024-05-31 03:14, Stefano Stabellini wrote: On Fri, 24 May 2024, Andrew Cooper wrote: Perform constant-folding unconditionally, rather than having it implemented inconsistency between architectures. Confirm the expected behaviour with compile time and boot time tests. For non-constant inpu

Re: [PATCH v2 06/13] xen/bitops: Implement ffs() in common logic

2024-05-30 Thread Stefano Stabellini
On Fri, 24 May 2024, Andrew Cooper wrote: > Perform constant-folding unconditionally, rather than having it implemented > inconsistency between architectures. > > Confirm the expected behaviour with compile time and boot time tests. > > For non-constant inputs, use arch_ffs() if provided but fall

Re: [PATCH v2 06/13] xen/bitops: Implement ffs() in common logic

2024-05-27 Thread Jan Beulich
On 24.05.2024 22:03, Andrew Cooper wrote: > Perform constant-folding unconditionally, rather than having it implemented > inconsistency between architectures. > > Confirm the expected behaviour with compile time and boot time tests. > > For non-constant inputs, use arch_ffs() if provided but fall

[PATCH v2 06/13] xen/bitops: Implement ffs() in common logic

2024-05-24 Thread Andrew Cooper
Perform constant-folding unconditionally, rather than having it implemented inconsistency between architectures. Confirm the expected behaviour with compile time and boot time tests. For non-constant inputs, use arch_ffs() if provided but fall back to generic_ffsl() if not. In particular, RISC-V