Re: [PATCH v2 05/14] x86/shstk: Re-layout the stack block for shadow stacks

2020-05-29 Thread Andrew Cooper
On 28/05/2020 13:33, Jan Beulich wrote: > On 27.05.2020 21:18, Andrew Cooper wrote: >> --- a/xen/arch/x86/traps.c >> +++ b/xen/arch/x86/traps.c >> @@ -365,20 +365,15 @@ static void show_guest_stack(struct vcpu *v, const >> struct cpu_user_regs *regs) >> /* >> * Notes for get_stack_trace_bottom(

Re: [PATCH v2 05/14] x86/shstk: Re-layout the stack block for shadow stacks

2020-05-28 Thread Jan Beulich
On 27.05.2020 21:18, Andrew Cooper wrote: > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -365,20 +365,15 @@ static void show_guest_stack(struct vcpu *v, const > struct cpu_user_regs *regs) > /* > * Notes for get_stack_trace_bottom() and get_stack_dump_bottom() > * > - * Stack

[PATCH v2 05/14] x86/shstk: Re-layout the stack block for shadow stacks

2020-05-27 Thread Andrew Cooper
We have two free pages in the current stack. A useful property of shadow stacks and regular stacks is that they act as each others guard pages as far as OoB writes go. Move the regular IST stacks up by one page, to allow their shadow stack page to be in slot 0. The primary shadow stack uses slot