Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-09-02 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow"): > And - just to make it very explicit - even if I went this route to > address a controversial point, I'd still like to understand the > reason for the original objection - if o

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-08-19 Thread Juergen Gross
On 19.08.21 13:51, Jan Beulich wrote: On 19.08.2021 13:25, Juergen Gross wrote: On 19.08.21 13:06, Jan Beulich wrote: On 19.08.2021 12:20, Juergen Gross wrote: On 05.07.21 17:13, Jan Beulich wrote: In send_memory_live() the precise value the dirty_count struct field gets initialized to doesn'

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-08-19 Thread Jan Beulich
On 19.08.2021 13:51, Jan Beulich wrote: > On 19.08.2021 13:25, Juergen Gross wrote: >> On 19.08.21 13:06, Jan Beulich wrote: >>> On 19.08.2021 12:20, Juergen Gross wrote: On 05.07.21 17:13, Jan Beulich wrote: > In send_memory_live() the precise value the dirty_count struct field > gets

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-08-19 Thread Jan Beulich
On 19.08.2021 13:25, Juergen Gross wrote: > On 19.08.21 13:06, Jan Beulich wrote: >> On 19.08.2021 12:20, Juergen Gross wrote: >>> On 05.07.21 17:13, Jan Beulich wrote: In send_memory_live() the precise value the dirty_count struct field gets initialized to doesn't matter much (apart from

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-08-19 Thread Juergen Gross
On 19.08.21 13:06, Jan Beulich wrote: On 19.08.2021 12:20, Juergen Gross wrote: On 05.07.21 17:13, Jan Beulich wrote: In send_memory_live() the precise value the dirty_count struct field gets initialized to doesn't matter much (apart from the triggering of the log message in send_dirty_pages(),

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-08-19 Thread Jan Beulich
On 19.08.2021 12:20, Juergen Gross wrote: > On 05.07.21 17:13, Jan Beulich wrote: >> In send_memory_live() the precise value the dirty_count struct field >> gets initialized to doesn't matter much (apart from the triggering of >> the log message in send_dirty_pages(), see below), but it is importan

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-08-19 Thread Juergen Gross
On 05.07.21 17:13, Jan Beulich wrote: In send_memory_live() the precise value the dirty_count struct field gets initialized to doesn't matter much (apart from the triggering of the log message in send_dirty_pages(), see below), but it is important that it not be zero on the first iteration (or el

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-07-06 Thread Olaf Hering
Am Tue, 6 Jul 2021 08:58:59 +0200 schrieb Jan Beulich : > Well, that's part of the current limitation. The size would need re-querying > before every iteration (or at the very least before the last one, after the > domain has been paused). Ah, you even wrote that. In addition each iteration shou

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-07-05 Thread Jan Beulich
On 06.07.2021 08:46, Olaf Hering wrote: > Am Tue, 6 Jul 2021 08:39:21 +0200 > schrieb Jan Beulich : > >> the size may change in the course of migration > > How can the p2m_size change? This upper limit is queried once, then > all loops take this as loop counter. Well, that's part of the current

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-07-05 Thread Olaf Hering
Am Tue, 6 Jul 2021 08:39:21 +0200 schrieb Jan Beulich : > the size may change in the course of migration How can the p2m_size change? This upper limit is queried once, then all loops take this as loop counter. Olaf

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-07-05 Thread Jan Beulich
On 05.07.2021 19:26, Olaf Hering wrote: > Am Mon, 5 Jul 2021 17:13:28 +0200 > schrieb Jan Beulich : > >> ctx->save.stats = (struct precopy_stats){ >> -.dirty_count = ctx->save.p2m_size, >> +.dirty_count = -1, >> }; > > As said earlier, a consumer of these data may now be

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-07-05 Thread Olaf Hering
Am Mon, 5 Jul 2021 17:13:28 +0200 schrieb Jan Beulich : > ctx->save.stats = (struct precopy_stats){ > -.dirty_count = ctx->save.p2m_size, > +.dirty_count = -1, > }; As said earlier, a consumer of these data may now be unable to initialize itself properly. Without the pa

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-07-05 Thread Jan Beulich
On 05.07.2021 17:41, Andrew Cooper wrote: > On 05/07/2021 16:13, Jan Beulich wrote: >> In send_memory_live() the precise value the dirty_count struct field >> gets initialized to doesn't matter much (apart from the triggering of >> the log message in send_dirty_pages(), see below), but it is import

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-07-05 Thread Andrew Cooper
On 05/07/2021 16:13, Jan Beulich wrote: > In send_memory_live() the precise value the dirty_count struct field > gets initialized to doesn't matter much (apart from the triggering of > the log message in send_dirty_pages(), see below), but it is important > that it not be zero on the first iteratio

[PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

2021-07-05 Thread Jan Beulich
In send_memory_live() the precise value the dirty_count struct field gets initialized to doesn't matter much (apart from the triggering of the log message in send_dirty_pages(), see below), but it is important that it not be zero on the first iteration (or else send_dirty_pages() won't get called a