Re: [PATCH v2 (resend) 07/27] x86: Map/unmap pages in restore_all_guests

2024-05-01 Thread Jan Beulich
On 30.04.2024 18:08, Elias El Yandouzi wrote: >>> --- a/xen/arch/x86/pv/domain.c >>> +++ b/xen/arch/x86/pv/domain.c >>> @@ -288,6 +288,19 @@ static void pv_destroy_gdt_ldt_l1tab(struct vcpu *v) >>> 1U << GDT_LDT_VCPU_SHIFT); >>> } >>> >>> +static int pv_create_s

Re: [PATCH v2 (resend) 07/27] x86: Map/unmap pages in restore_all_guests

2024-04-30 Thread Elias El Yandouzi
Hi Jan, From: Hongyan Xia Before, it assumed the pv cr3 could be accessed via a direct map. This is no longer true. There are a number of terminology issues here, starting with the title: Unlike (iirc) in an earlier version, no mapping/unmapping occurs in restore_all_guests itself anymore.

Re: [PATCH v2 (resend) 07/27] x86: Map/unmap pages in restore_all_guests

2024-02-20 Thread Jan Beulich
On 16.01.2024 20:25, Elias El Yandouzi wrote: > From: Hongyan Xia > > Before, it assumed the pv cr3 could be accessed via a direct map. This > is no longer true. There are a number of terminology issues here, starting with the title: Unlike (iirc) in an earlier version, no mapping/unmapping occu

[PATCH v2 (resend) 07/27] x86: Map/unmap pages in restore_all_guests

2024-01-16 Thread Elias El Yandouzi
From: Hongyan Xia Before, it assumed the pv cr3 could be accessed via a direct map. This is no longer true. Note that we do not map and unmap root_pgt for now since it is still a xenheap page. Signed-off-by: Hongyan Xia Signed-off-by: Julien Grall Signed-off-by: Elias El Yandouzi