Re: [PATCH v2] xen: don't continue xenstore initialization in case of errors

2021-11-17 Thread Boris Ostrovsky
On 11/15/21 5:27 PM, Stefano Stabellini wrote: From: Stefano Stabellini In case of errors in xenbus_init (e.g. missing xen_store_gfn parameter), we goto out_error but we forget to reset xen_store_domain_type to XS_UNKNOWN. As a consequence xenbus_probe_initcall and other initcalls will still

Re: [PATCH v2] xen: don't continue xenstore initialization in case of errors

2021-11-16 Thread Stefano Stabellini
On Tue, 16 Nov 2021, Jan Beulich wrote: > On 15.11.2021 23:27, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > In case of errors in xenbus_init (e.g. missing xen_store_gfn parameter), > > we goto out_error but we forget to reset xen_store_domain_type to > > XS_UNKNOWN. As a consequ

Re: [PATCH v2] xen: don't continue xenstore initialization in case of errors

2021-11-15 Thread Jan Beulich
On 15.11.2021 23:27, Stefano Stabellini wrote: > From: Stefano Stabellini > > In case of errors in xenbus_init (e.g. missing xen_store_gfn parameter), > we goto out_error but we forget to reset xen_store_domain_type to > XS_UNKNOWN. As a consequence xenbus_probe_initcall and other initcalls > wil

[PATCH v2] xen: don't continue xenstore initialization in case of errors

2021-11-15 Thread Stefano Stabellini
From: Stefano Stabellini In case of errors in xenbus_init (e.g. missing xen_store_gfn parameter), we goto out_error but we forget to reset xen_store_domain_type to XS_UNKNOWN. As a consequence xenbus_probe_initcall and other initcalls will still try to initialize xenstore resulting into a crash a