Re: [PATCH v2] xen/pcifront: Removed unnecessary __ref annotation

2021-09-01 Thread Juergen Gross
On 30.08.21 19:53, Sergio Miguéns Iglesias wrote: An unnecessary "__ref" annotation was removed from the "drivers/pci/xen_pcifront.c" file. The function where the annotation was used was "pcifront_backend_changed()", which does not call any functions annotated as "__*init" nor "__*exit". This mak

Re: [PATCH v2] xen/pcifront: Removed unnecessary __ref annotation

2021-08-30 Thread Bjorn Helgaas
On Mon, Aug 30, 2021 at 10:14:26PM +0200, Sergio Miguéns Iglesias wrote: > Thanks again for you answers! > I am lerning a lot from your replys and I really appreciate it. Should I > make a v3 patch and split that one into 2 different patches or would it > be confusing? > > I don't want to take mor

Re: [PATCH v2] xen/pcifront: Removed unnecessary __ref annotation

2021-08-30 Thread Sergio Miguéns Iglesias
Never mind, it got accepted anyways, but I will 100% fix my commit messages for my future patches. I really appreciate your suggestions and the time you have put into writing them. I will improve in my next commits :) Sergio M. Iglesias. On 21/08/30 11:29, Bjorn Helgaas wrote: > On Mon, Aug 30,

Re: [PATCH v2] xen/pcifront: Removed unnecessary __ref annotation

2021-08-30 Thread Sergio Miguéns Iglesias
Thanks again for you answers! I am lerning a lot from your replys and I really appreciate it. Should I make a v3 patch and split that one into 2 different patches or would it be confusing? I don't want to take more of your time with poor patches so I don't know if I should resend this one. Thanks

Re: [PATCH v2] xen/pcifront: Removed unnecessary __ref annotation

2021-08-30 Thread Bjorn Helgaas
On Mon, Aug 30, 2021 at 07:53:05PM +0200, Sergio Miguéns Iglesias wrote: > An unnecessary "__ref" annotation was removed from the > "drivers/pci/xen_pcifront.c" file. The function where the annotation > was used was "pcifront_backend_changed()", which does not call any > functions annotated as "__*

Re: [PATCH v2] xen/pcifront: Removed unnecessary __ref annotation

2021-08-30 Thread Juergen Gross
On 30.08.21 19:53, Sergio Miguéns Iglesias wrote: An unnecessary "__ref" annotation was removed from the "drivers/pci/xen_pcifront.c" file. The function where the annotation was used was "pcifront_backend_changed()", which does not call any functions annotated as "__*init" nor "__*exit". This mak

[PATCH v2] xen/pcifront: Removed unnecessary __ref annotation

2021-08-30 Thread Sergio Miguéns Iglesias
An unnecessary "__ref" annotation was removed from the "drivers/pci/xen_pcifront.c" file. The function where the annotation was used was "pcifront_backend_changed()", which does not call any functions annotated as "__*init" nor "__*exit". This makes "__ref" unnecessary since this annotation is used