Re: [PATCH v2] xen/mm: pg_offlined can be defined as bool in free_heap_pages()

2022-02-24 Thread Julien Grall
Hi Andrew, On 23/02/2022 19:38, Andrew Cooper wrote: On 23/02/2022 19:08, Julien Grall wrote: From: Julien Grall The local variable pg_offlined in free_heap_pages() can only take two values. So switch it to a bool. Signed-off-by: Julien Grall I'd argue this might want to go as far as decl

Re: [PATCH v2] xen/mm: pg_offlined can be defined as bool in free_heap_pages()

2022-02-23 Thread Andrew Cooper
On 23/02/2022 19:08, Julien Grall wrote: > From: Julien Grall > > The local variable pg_offlined in free_heap_pages() can only take two > values. So switch it to a bool. > > Signed-off-by: Julien Grall I'd argue this might want to go as far as declaring Fixes: 289610483fc43 which really did intr

[PATCH v2] xen/mm: pg_offlined can be defined as bool in free_heap_pages()

2022-02-23 Thread Julien Grall
From: Julien Grall The local variable pg_offlined in free_heap_pages() can only take two values. So switch it to a bool. Signed-off-by: Julien Grall --- Changes in v2: - pg_offlined should be initialized to false rather than true --- xen/common/page_alloc.c | 5 +++-- 1 file chang