Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state

2022-05-25 Thread Jan Beulich
On 25.05.2022 09:46, Roger Pau Monné wrote: > On Wed, May 25, 2022 at 09:34:32AM +0200, Jan Beulich wrote: >> On 25.05.2022 09:21, Roger Pau Monné wrote: >>> On Wed, May 25, 2022 at 08:02:17AM +0200, Jan Beulich wrote: On 24.05.2022 18:46, Roger Pau Monné wrote: > Would you be fine with ad

Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state

2022-05-25 Thread Roger Pau Monné
On Wed, May 25, 2022 at 09:34:32AM +0200, Jan Beulich wrote: > On 25.05.2022 09:21, Roger Pau Monné wrote: > > On Wed, May 25, 2022 at 08:02:17AM +0200, Jan Beulich wrote: > >> On 24.05.2022 18:46, Roger Pau Monné wrote: > >>> Would you be fine with adding: > >>> > >>> Note that FLUSH_FORCE_IPI doe

Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state

2022-05-25 Thread Jan Beulich
On 25.05.2022 09:21, Roger Pau Monné wrote: > On Wed, May 25, 2022 at 08:02:17AM +0200, Jan Beulich wrote: >> On 24.05.2022 18:46, Roger Pau Monné wrote: >>> Would you be fine with adding: >>> >>> Note that FLUSH_FORCE_IPI doesn't need to be handled explicitly, as >>> it's main purpose is to preven

Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state

2022-05-25 Thread Roger Pau Monné
On Wed, May 25, 2022 at 08:02:17AM +0200, Jan Beulich wrote: > On 24.05.2022 18:46, Roger Pau Monné wrote: > > On Tue, May 24, 2022 at 05:27:35PM +0200, Jan Beulich wrote: > >> On 24.05.2022 12:50, Roger Pau Monne wrote: > >>> Booting with Shadow Stacks leads to the following assert on a debug > >>

Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state

2022-05-24 Thread Jan Beulich
On 24.05.2022 18:46, Roger Pau Monné wrote: > On Tue, May 24, 2022 at 05:27:35PM +0200, Jan Beulich wrote: >> On 24.05.2022 12:50, Roger Pau Monne wrote: >>> Booting with Shadow Stacks leads to the following assert on a debug >>> hypervisor: >>> >>> Assertion 'local_irq_is_enabled()' failed at arch

Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state

2022-05-24 Thread Roger Pau Monné
On Tue, May 24, 2022 at 05:27:35PM +0200, Jan Beulich wrote: > On 24.05.2022 12:50, Roger Pau Monne wrote: > > Booting with Shadow Stacks leads to the following assert on a debug > > hypervisor: > > > > Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 > > [ Xen-4.17.0-10.24-d x

Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state

2022-05-24 Thread Jan Beulich
On 24.05.2022 12:50, Roger Pau Monne wrote: > Booting with Shadow Stacks leads to the following assert on a debug > hypervisor: > > Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 > [ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted ] > CPU:0 > RIP:e008:[] flush_are

[PATCH v2] x86/flushtlb: remove flush_area check on system state

2022-05-24 Thread Roger Pau Monne
Booting with Shadow Stacks leads to the following assert on a debug hypervisor: Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 [ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted ] CPU:0 RIP:e008:[] flush_area_mask+0x40/0x13e [...] Xen call trace: [] R flush_area