Re: [PATCH v2] libs/light: make it build without setresuid()

2021-01-30 Thread Manuel Bouyer
On Fri, Jan 29, 2021 at 11:05:24PM +, Andrew Cooper wrote: > On 29/01/2021 23:01, Manuel Bouyer wrote: > > On Fri, Jan 29, 2021 at 10:51:14PM +, Andrew Cooper wrote: > >> Given the freeze, and discussions on IRC, I have committed most of this > >> series. > > thanks > > > >> This particular

Re: [PATCH v2] libs/light: make it build without setresuid()

2021-01-29 Thread Manuel Bouyer
On Fri, Jan 29, 2021 at 11:05:24PM +, Andrew Cooper wrote: > On 29/01/2021 23:01, Manuel Bouyer wrote: > > On Fri, Jan 29, 2021 at 10:51:14PM +, Andrew Cooper wrote: > >> Given the freeze, and discussions on IRC, I have committed most of this > >> series. > > thanks > > > >> This particular

Re: [PATCH v2] libs/light: make it build without setresuid()

2021-01-29 Thread Andrew Cooper
On 29/01/2021 23:01, Manuel Bouyer wrote: > On Fri, Jan 29, 2021 at 10:51:14PM +, Andrew Cooper wrote: >> Given the freeze, and discussions on IRC, I have committed most of this >> series. > thanks > >> This particular patch doesn't compile, but I fixed it up. >> >> Still outstanding are "NetBS

Re: [PATCH v2] libs/light: make it build without setresuid()

2021-01-29 Thread Manuel Bouyer
On Fri, Jan 29, 2021 at 10:51:14PM +, Andrew Cooper wrote: > > Given the freeze, and discussions on IRC, I have committed most of this > series. thanks > > This particular patch doesn't compile, but I fixed it up. > > Still outstanding are "NetBSD: use system-provided headers", the I just

Re: [PATCH v2] libs/light: make it build without setresuid()

2021-01-29 Thread Andrew Cooper
On 26/01/2021 22:47, Manuel Bouyer wrote: > diff --git a/tools/libs/light/libxl_setresuid.c > b/tools/libs/light/libxl_setresuid.c > new file mode 100644 > index 00..ac5cb5db53 > --- /dev/null > +++ b/tools/libs/light/libxl_setresuid.c > @@ -0,0 +1,23 @@ > +/* > + * Copyright (C) 2021 > +

Re: [PATCH v2] libs/light: make it build without setresuid()

2021-01-28 Thread Ian Jackson
Manuel Bouyer writes ("[PATCH v2] libs/light: make it build without setresuid()"): > NetBSD doesn't have setresuid(). introcuce libxl__setresuid(), > which on NetBSD assert() that it's never called (it should not be called when > dm restriction is off, and NetBSD does

[PATCH v2] libs/light: make it build without setresuid()

2021-01-26 Thread Manuel Bouyer
NetBSD doesn't have setresuid(). introcuce libxl__setresuid(), which on NetBSD assert() that it's never called (it should not be called when dm restriction is off, and NetBSD doesn't support dm restriction at this time). On linux and FreeBSD it just calls setresuid(). Signed-off-by: Manuel Bouyer