Re: [PATCH v2] lib: drop (replace) debug_build()

2021-01-13 Thread Julien Grall
Hi Jan, On 23/12/2020 16:05, Jan Beulich wrote: Its expansion shouldn't be tied to NDEBUG - down the road we may want to allow enabling assertions independently of CONFIG_DEBUG. Replace the few uses by a new xen_build_info() helper, subsuming gcov_string at the same time (while replacing the sta

Re: [PATCH v2] lib: drop (replace) debug_build()

2020-12-23 Thread Andrew Cooper
On 23/12/2020 16:59, Jan Beulich wrote: > On 23.12.2020 17:53, Andrew Cooper wrote: >> On 23/12/2020 16:05, Jan Beulich wrote: >>> Its expansion shouldn't be tied to NDEBUG - down the road we may want to >>> allow enabling assertions independently of CONFIG_DEBUG. Replace the few >>> uses by a new

Re: [PATCH v2] lib: drop (replace) debug_build()

2020-12-23 Thread Jan Beulich
On 23.12.2020 17:53, Andrew Cooper wrote: > On 23/12/2020 16:05, Jan Beulich wrote: >> Its expansion shouldn't be tied to NDEBUG - down the road we may want to >> allow enabling assertions independently of CONFIG_DEBUG. Replace the few >> uses by a new xen_build_info() helper, subsuming gcov_string

Re: [PATCH v2] lib: drop (replace) debug_build()

2020-12-23 Thread Andrew Cooper
On 23/12/2020 16:05, Jan Beulich wrote: > Its expansion shouldn't be tied to NDEBUG - down the road we may want to > allow enabling assertions independently of CONFIG_DEBUG. Replace the few > uses by a new xen_build_info() helper, subsuming gcov_string at the same > time (while replacing the stale

[PATCH v2] lib: drop (replace) debug_build()

2020-12-23 Thread Jan Beulich
Its expansion shouldn't be tied to NDEBUG - down the road we may want to allow enabling assertions independently of CONFIG_DEBUG. Replace the few uses by a new xen_build_info() helper, subsuming gcov_string at the same time (while replacing the stale CONFIG_GCOV used there) and also adding CONFIG_U