Re: [PATCH v2] build: Fix make warning if there is no cppcheck

2022-05-20 Thread Bertrand Marquis
Hi Jan, > On 20 May 2022, at 14:56, Jan Beulich wrote: > > On 20.05.2022 15:23, Bertrand Marquis wrote: >>> On 20 May 2022, at 13:51, Jan Beulich wrote: >>> On 20.05.2022 14:14, Bertrand Marquis wrote: --- a/xen/Makefile +++ b/xen/Makefile @@ -694,12 +694,14 @@ $(objtree)/%.c.cpp

Re: [PATCH v2] build: Fix make warning if there is no cppcheck

2022-05-20 Thread Jan Beulich
On 20.05.2022 15:23, Bertrand Marquis wrote: >> On 20 May 2022, at 13:51, Jan Beulich wrote: >> On 20.05.2022 14:14, Bertrand Marquis wrote: >>> --- a/xen/Makefile >>> +++ b/xen/Makefile >>> @@ -694,12 +694,14 @@ $(objtree)/%.c.cppcheck: $(srctree)/%.c >>> $(objtree)/include/generated/autoconf.h

Re: [PATCH v2] build: Fix make warning if there is no cppcheck

2022-05-20 Thread Bertrand Marquis
Hi, > On 20 May 2022, at 13:51, Jan Beulich wrote: > > On 20.05.2022 14:14, Bertrand Marquis wrote: >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -694,12 +694,14 @@ $(objtree)/%.c.cppcheck: $(srctree)/%.c >> $(objtree)/include/generated/autoconf.h >> $(call if_changed,cppcheck_xml) >>

Re: [PATCH v2] build: Fix make warning if there is no cppcheck

2022-05-20 Thread Jan Beulich
On 20.05.2022 14:14, Bertrand Marquis wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -694,12 +694,14 @@ $(objtree)/%.c.cppcheck: $(srctree)/%.c > $(objtree)/include/generated/autoconf.h > $(call if_changed,cppcheck_xml) > > cppcheck-version: > -ifeq ($(shell which $(CPPCHECK)),) >

[PATCH v2] build: Fix make warning if there is no cppcheck

2022-05-20 Thread Bertrand Marquis
If cppcheck is not present, the following warning appears during build: which: no cppcheck in ([...]) /bin/sh: cppcheck: command not found Fix the problem by using shell code inside the cppcheck-version rule to also prevent unneeded call of which when something else than cppcheck is built. Report